Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve which coin gets selected when buying small amounts #8

Open
wizche opened this issue Apr 19, 2021 · 2 comments
Open

Improve which coin gets selected when buying small amounts #8

wizche opened this issue Apr 19, 2021 · 2 comments

Comments

@wizche
Copy link
Owner

wizche commented Apr 19, 2021

For example with topmarket cap:

Market cap BTC: 1040470295876 USD
Market cap ETH: 250834978368 USD
Market cap ADA: 39296042631 USD
Market cap LTC: 17839898779 USD
Market cap BCH: 17296375715 USD
Market cap LINK: 15483775118 USD
Market cap XLM: 11902996519 USD
Market cap FIL: 10605577409 USD

BTC-EUR too small (7.5000 < 10.0000), adding to next product ETH-EUR = 15.0000 (min 10.0000)
LTC-EUR too small (7.5000 < 10.0000), adding to next product BCH-EUR = 15.0000 (min 10.0000)
LINK-EUR too small (7.5000 < 10.0000), adding to next product XLM-EUR = 15.0000 (min 0.1000)

It should work the opposite way, the one with less market capital should be added to the top one.
In get_buy_quotes we just pick the next product in the order list if the amount is too small, but actually we should add that amount to the product on the top (most "important") which hasnt yet reached the minimum amount.

@deadc0de6
Copy link
Collaborator

What I´m not sure to understand is if we select 10 products (as user wants to invest in 10) and then re-attribute to a different product if it´s below the minimum required to buy, then in the end we won´t buy 10 products but less?

@wizche
Copy link
Owner Author

wizche commented Apr 20, 2021

Yes i fear we can't do much about that... but we can buy at least the "best" ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants