Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mysterious scale factor for MERL BRDF? #5

Open
shocker-0x15 opened this issue Jul 20, 2023 · 0 comments
Open

Mysterious scale factor for MERL BRDF? #5

shocker-0x15 opened this issue Jul 20, 2023 · 0 comments

Comments

@shocker-0x15
Copy link

Hello,

I have noticed that this code uses a scale factor x2 for MERL BRDF data:

data[j] = storage[ind+ch*header.res_theta_h*header.res_theta_d*header.res_phi_d] * scale[ch] * 2; /// XXX too dark?

Is there any basis for this value? or is this just competely ad-hoc?
(I certainly feel materials look too dark with raw MERL BRDF, but I'm not sure the reason.)

Best regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant