From b0d2af932668044abf2f4198b44c758cb32e2c9c Mon Sep 17 00:00:00 2001 From: wlandau Date: Mon, 20 Mar 2023 09:59:18 -0400 Subject: [PATCH] Address CRAN feedback --- DESCRIPTION | 13 ++++++++----- NEWS.md | 4 ++-- inst/WORDLIST | 2 ++ tests/testthat/test-crew_eval.R | 3 +++ 4 files changed, 15 insertions(+), 7 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index ead1e206..0b49e587 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -4,16 +4,19 @@ Description: In computationally demanding analysis projects, statisticians and data scientists asynchronously deploy long-running tasks to distributed systems, ranging from traditional clusters to cloud services - The 'NNG'-powered 'mirai' R package is a sleek + The 'NNG'-powered 'mirai' R package by Gao (2023) + is a sleek and sophisticated scheduler that efficiently processes these intense workloads. The 'crew' package extends 'mirai' with a unifying interface for third-party worker launchers. Inspiration also comes from packages - 'future' (2021, ), 'rrq', - 'clustermq' (2019, ), - and 'batchtools' (2017, ). -Version: 0.0.3.9000 + 'future' by Bengtsson (2021) , + 'rrq' by FitzJohn and Ashton (2023) , + 'clustermq' by Schubert (2019) ), + and 'batchtools' by Lang, Bischel, and Surmann (2017) + . +Version: 0.0.4 License: MIT + file LICENSE URL: https://wlandau.github.io/crew/, https://github.com/wlandau/crew BugReports: https://github.com/wlandau/crew/issues diff --git a/NEWS.md b/NEWS.md index b8db079f..cce09d40 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,6 +1,6 @@ -# crew 0.0.3.9000 - +# crew 0.0.4 +* Adjust references and tests as requested by CRAN. # crew 0.0.3 diff --git a/inst/WORDLIST b/inst/WORDLIST index d2b6e62f..823acead 100644 --- a/inst/WORDLIST +++ b/inst/WORDLIST @@ -89,3 +89,5 @@ CloudWatch MERCHANTABILITY NONINFRINGEMENT Tidyselect +Bischel +Surmann diff --git a/tests/testthat/test-crew_eval.R b/tests/testthat/test-crew_eval.R index 930b6664..c94f3b9d 100644 --- a/tests/testthat/test-crew_eval.R +++ b/tests/testthat/test-crew_eval.R @@ -137,6 +137,8 @@ crew_test("crew_eval() environment variables", { crew_test("crew_eval() options", { skip_on_cran() + old_options <- options() + on.exit(options(old_options)) # Reset to old options on exit. expect_null(getOption("crew_option_1")) expect_null(getOption("crew_option_2")) expect_lt(getOption("warn"), 10) @@ -161,4 +163,5 @@ crew_test("crew_eval() options", { warn = 10L ) ) + options(old_options) # Reset to old options. })