Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Target Selectors #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

densestvoid
Copy link

Adding support to define Target Selectors for use in commands

Target Selector struct with commands to add arguments.
String function converts the TargetSelector struct to the string format expected in Minecraft commands
Commands and Events as interfaces allow other packages to be written and use this engine for mods and datapacks, and well as previous minecraft versions
}

// Constants of minecraft entity IDs
const (
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would personally leave out the minecraft specific data to https://github.com/PrismarineJS/minecraft-data instead. I currently looking into making go-wrapper version to code gen entities based on current version for this purpose.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that is a nice repo. Yeah, no worries, I can remove the constants

@@ -0,0 +1,431 @@
package wrapper
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would target_selectors not belong in the command package/dir? what do you think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bad spot for it. Its very much a WIP and I keep restructuring

Copy link
Owner

@wlwanpan wlwanpan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a side note, I dont think we need to namespace with 'java' since there is no plan to ever support cross platform :) maybe consider changing "commands/java/1.15.2/" -> "commands/1.15.2/".

@densestvoid
Copy link
Author

Ok, no worries. I will try to have this finished by the end of March as well. Thanks!

@wlwanpan
Copy link
Owner

Ok, no worries. I will try to have this finished by the end of March as well. Thanks!

np no rush at all on that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants