Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCMP2 ID s/reco/recommended/g #65

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

WCMP2 ID s/reco/recommended/g #65

wants to merge 2 commits into from

Conversation

tomkralidis
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@maaikelimper maaikelimper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not convinced this update is required. The metadata-id needs to be unique for each dataset, there is no requirement for it to contain the fully spelled out data-policy.

If we do want to include the word "recommended" in the metadata-id I would bundle this with an update to abbreviate the metadata-id in the templates to avoid strings exceeding the size of the display in the form.

src/components/DatasetEditorForm.vue Outdated Show resolved Hide resolved
@tomkralidis
Copy link
Collaborator Author

Correct, there is no requirement for the "local identifier" token of a WCMP2 id. At the same time, in the wis2box context there is an inconsistency ("core -> core", "recommended" -> "reco"), driven by a user interface layout.

I'm fine if we can discuss a consistent approach to "local" identifiers in wis2box without morphing official values into conventions driven by a UI.

@maaikelimper
Copy link
Collaborator

maaikelimper commented Nov 29, 2024

How about we use "rcmd" instead of "reco" or "recommended" in the id as the wis2box-convention ?

@tomkralidis
Copy link
Collaborator Author

tomkralidis commented Nov 29, 2024

If we are going to use the WTH data policy as part of the WCMP2 id, then we should use the canonical values and not aliases or shortcuts/conventions. Is there even a requirement for having the data policy as part of the WCMP2 id?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants