Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Year-Wise tab should have their own url #108

Open
TheFlash98 opened this issue Jun 11, 2017 · 6 comments
Open

Year-Wise tab should have their own url #108

TheFlash98 opened this issue Jun 11, 2017 · 6 comments
Labels

Comments

@TheFlash98
Copy link
Member

TheFlash98 commented Jun 11, 2017

If we click on a certain year's tab in events, the url remains the same http://wncc-iitb.org/events/
It would be better if the link is something like http://wncc-iitb.org/events/year?=2016 or something. I remember someone did it before.

@Owl-A
Copy link
Collaborator

Owl-A commented Jun 11, 2017

Are you sure? I don't think this is correct in practice. 😕

@grubdragon
Copy link
Collaborator

Events are pretty less. Overkill lag raha hai 👀

@nihal111
Copy link
Member

I think @ydidwania had achieved this before. Can you find out what broke it and fix it? 🙂

@grubdragon
Copy link
Collaborator

Right now we are loading everything(all events) and tabbing them

@Owl-A
Copy link
Collaborator

Owl-A commented Jun 13, 2017

I agree with grub, @Nihal isn't that done for different pages 😕

@nihal111
Copy link
Member

nihal111 commented Jun 14, 2017

Yeah, I agree it's not exactly the "right" way. But to do that with different pages, you need to have a backend that understands the GET request parameters. Since we are using Jekyll, if we want to do this, it'd have to be the Javascript way.

About whether or not we need it, we do have a good number of tabs. It might be a good idea to have a different link for each one of them to ease sharing. Kind of like how the part after the # in https://github.com/nihal111/WnCC/issues/108#issuecomment-3082435620 takes you to that element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants