You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have the feeling, that the positioning logic in this library is a bit shaky. That's not a criticism, because it's very hard to do, but I have the feeling that Svelte could do a lot of the heavy lifting there.
Instead of calculating the heights, and animating between them programmatically, you could just use an in: and out: animation, to automatically transition between the different positions the toasts are displayed at. This way, the layout of the toasts could be done by the CSS layout engine (by simply placing them in a flexbox for example) and the animation between these states would be automatic.
Would you be interested in attacking such a change?
This discussion was converted from issue #25 on January 05, 2024 06:38.
Heading
Bold
Italic
Quote
Code
Link
Numbered list
Unordered list
Task list
Attach files
Mention
Reference
Menu
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I have the feeling, that the positioning logic in this library is a bit shaky. That's not a criticism, because it's very hard to do, but I have the feeling that Svelte could do a lot of the heavy lifting there.
Instead of calculating the heights, and animating between them programmatically, you could just use an
in:
andout:
animation, to automatically transition between the different positions the toasts are displayed at. This way, the layout of the toasts could be done by the CSS layout engine (by simply placing them in a flexbox for example) and the animation between these states would be automatic.Would you be interested in attacking such a change?
Beta Was this translation helpful? Give feedback.
All reactions