Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize advantage function #6

Open
rarilurelo opened this issue Jan 5, 2017 · 2 comments
Open

Normalize advantage function #6

rarilurelo opened this issue Jan 5, 2017 · 2 comments

Comments

@rarilurelo
Copy link

Hi, thanks for your implementation of TRPO.

In https://github.com/wojzaremba/trpo/blob/master/main.py#L128-L132 you normalize an advantage function.
I couldn't find any description about this operation in the paper( https://arxiv.org/abs/1502.05477 ).
Why did you do that?

@wojzaremba
Copy link
Owner

I have found it in John Schulman's code. This normalization is biased, but it's sensible.

@rarilurelo
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants