Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Comprehensive Espressif Math Tests #6385

Closed
gojimmypi opened this issue May 5, 2023 · 1 comment
Closed

Feature Request: Comprehensive Espressif Math Tests #6385

gojimmypi opened this issue May 5, 2023 · 1 comment
Assignees

Comments

@gojimmypi
Copy link
Contributor

gojimmypi commented May 5, 2023

Version

latest master

Description

As noted in #6380, there were some unexpected and incorrect Espressif math results as related to fp_int data provided from HW acceleration and the use (or lack thereof) fully initialized fp_int data structures.

There's also the handling of the used size value for values such as fp_int = 1 in fp_cmp. (e.g. should values of used=1 and used=8 be considered equal? currently they are not)

As noted in the comment, there may be peripheral consequences to the changes I've proposed in #6382.

I will be looking into any undesired side effects. Indeed if other functions have a similar, incorrect handling of the used scope, I could imagine a situation where a test might fail. The test itself may need to be addressed.

In any case, this issue is a Feature Request to add more comprehensive math testing to wolfcrypt/test that would have caught the fp_add and fp_cmp problems for Espressif and any other Hardware Acceleration that may be inserted into known, good math libraries.

@gojimmypi gojimmypi self-assigned this May 5, 2023
@gojimmypi gojimmypi changed the title Feature Request: Comprehensive Math Tests Feature Request: Comprehensive Espressif Math Tests May 5, 2023
@gojimmypi
Copy link
Contributor Author

I have some additional hardware-specific tests in my test.c that I'll add at some later date.

Closing this lingering stale issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant