Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep State of BottoSheetPage after pushing #252

Open
blingkonnerth opened this issue Jul 3, 2024 · 2 comments
Open

Keep State of BottoSheetPage after pushing #252

blingkonnerth opened this issue Jul 3, 2024 · 2 comments
Labels
bug Something isn't working enhancement New feature or request in triage

Comments

@blingkonnerth
Copy link

Bug report

Describe the bug
When pushing to the next page, via WoltModalSheet.of(this).pushPage, the current page will be disposed.

Is there a way to prevent this behavior? I think it's quite counter-intuitive.

In my opinion the State should only be disposed after a pop.

Steps to reproduce

Steps to reproduce the behavior:

Simply call pushPage and make a breakpoint in your dispose - method inside the current widget.
@blingkonnerth blingkonnerth added bug Something isn't working in triage labels Jul 3, 2024
@ulusoyca ulusoyca added the enhancement New feature or request label Jul 4, 2024
@ulusoyca
Copy link
Collaborator

ulusoyca commented Jul 4, 2024

This is a valid one. Thanks for the feedback. We will consider this. Keeping this issue open until it is there.

@ulusoyca
Copy link
Collaborator

ulusoyca commented Jul 9, 2024

This will be addressed with the next release. Currently working on converting the page class to widget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request in triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ulusoyca @blingkonnerth