Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix order summary quantity badge numbers styling for checkout block used with the theme. #58

Closed
nerrad opened this issue Feb 22, 2021 · 2 comments · Fixed by #66 · May be fixed by #62
Closed

Fix order summary quantity badge numbers styling for checkout block used with the theme. #58

nerrad opened this issue Feb 22, 2021 · 2 comments · Fixed by #66 · May be fixed by #62
Assignees
@nerrad
Labels
category: blocks Work related to integration with GB Blocks (Woo or otherwise) type: bug The issue is a confirmed bug.

Comments

@nerrad
Copy link
Contributor

nerrad commented Feb 22, 2021

Describe the bug

The order summary badges for quantities in Cart and Checkout blocks aren't legible (the text color blends in with background). Screenshot:

screenshot-bad

To Reproduce

Steps to reproduce the behavior:

  1. Install and activate WooCommerce Blocks feature plugin.
  2. Insert the Cart block on a page.
  3. Add some items to the cart then view the page you added the Cart block to.
  4. View the styling of the quantity badges for the items in the cart.

Expected behavior

Suggest leaving the style of the badges to what the blocks provide by default.
@nerrad nerrad added category: blocks Work related to integration with GB Blocks (Woo or otherwise) type: bug The issue is a confirmed bug. labels Feb 22, 2021
@nerrad nerrad mentioned this issue Feb 22, 2021
Closed
@luislard luislard self-assigned this Apr 28, 2021
@luislard
Copy link
Contributor

Cannot replicate @nerrad . CC: @jconroy
See:
image

Best,
Luis

@luislard luislard assigned jconroy and nerrad and unassigned luislard Apr 28, 2021
@luislard
Copy link
Contributor

@nerrad ,
I think you refer to the checkout component in the steps to replicate.

I will submit a PR

This was referenced Apr 28, 2021
Closed
Open
@nerrad nerrad assigned luislard and unassigned jconroy and nerrad May 18, 2021
@luislard luislard assigned nerrad and unassigned luislard May 20, 2021
@luislard luislard mentioned this issue May 20, 2021
Merged
5 tasks
@nerrad nerrad assigned luislard and unassigned nerrad May 21, 2021
@luislard luislard assigned nerrad and unassigned luislard Jun 17, 2021
@nerrad nerrad changed the title Fix order summary quantity badge numbers styling for cart and checkout blocks used with the theme. Fix order summary quantity badge numbers styling for checkout block used with the theme. Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nerrad nerrad

Labels
category: blocks Work related to integration with GB Blocks (Woo or otherwise) type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
No milestone
3 participants
@jconroy @nerrad @luislard