Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding: Remove Google MC and Google Ads Cards #2565

Closed
1 of 5 tasks
Tracked by #2509
joemcgill opened this issue Aug 23, 2024 · 7 comments · Fixed by #2585
Closed
1 of 5 tasks
Tracked by #2509

Onboarding: Remove Google MC and Google Ads Cards #2565

joemcgill opened this issue Aug 23, 2024 · 7 comments · Fixed by #2585
Assignees

Comments

@joemcgill
Copy link
Collaborator

joemcgill commented Aug 23, 2024

As part of #2509, we will be consolidating the UI for connecting to Google Merchant Center and Google Ads accounts into a unified UI with the GoogleAccountCard.

To begin this effort, we'll remove the existing GoogleAdsAccountCard and GoogleMCAccountCard components from the SetupAccounts flow of the onboarding flow.

image

Acceptance Criteria

  • The Google Ads card is not shown on step one of onboarding
  • The Google Merchant Center card is not shown on step one of onboarding
  • The disclaimer text associated with the MC card GoogleMCDisclaimer is moved to the footer next to the FAQs (see screenshot).
  • The continue button remains disabled even after the WP.com and Google cards are connected.
  • UI changes showed in the Google card are out of scope of this issue.

Implementation Brief

Note

This work should be branched from feature/2458-streamline-onboarding and a PR should be created against the feature/2458-consolidate-google-account-cards branch.

The SetupAccounts component that needs to be edited is here.

Test Coverage

Definition Questions

@joemcgill joemcgill changed the title Onboarding: Remove Google MC and Google Ads Card Onboarding: Remove Google MC and Google Ads Cards Aug 23, 2024
@joemcgill
Copy link
Collaborator Author

@eason9487 would you mind validating this subtask? The goal of this one is just to set up the UI ahead of the consolidation effort being worked on via all of the #2509 tasks.

@joemcgill
Copy link
Collaborator Author

I don't think there is much risk in getting started with this, so I'm marking this as ready for work to unblock the start of this effort.

@eason9487
Copy link
Member

Not sure how the original disconnect function for each account card will be consolidated into the new UI during onboarding?

@joemcgill
Copy link
Collaborator Author

@ankitguptaindia this is ready for QA. Note that this is a sub-task of #2509, so the onboarding flow will not be able to be completed until the whole feature is complete.

@eason9487

Not sure how the original disconnect function for each account card will be consolidated into the new UI during onboarding?

All of the functionality handled by the separate cards will be handled within the consolidated UI being started in #2566 as part of #2509.

@ankitguptaindia ankitguptaindia removed their assignment Sep 6, 2024
@eclarke1
Copy link
Collaborator

eclarke1 commented Sep 9, 2024

Engineering complete and approved, moving to UAT for @fblascogarma final approval

@eclarke1
Copy link
Collaborator

eclarke1 commented Sep 9, 2024

Just tagging @joemcgill and @dsawardekar to advise this needs to be merged please

@mikkamp
Copy link
Contributor

mikkamp commented Dec 2, 2024

Closing this as completed since it was part of the 2.9 release.

@mikkamp mikkamp closed this as completed Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment