-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding: Remove Google MC and Google Ads Cards #2565
Comments
@eason9487 would you mind validating this subtask? The goal of this one is just to set up the UI ahead of the consolidation effort being worked on via all of the #2509 tasks. |
I don't think there is much risk in getting started with this, so I'm marking this as ready for work to unblock the start of this effort. |
Not sure how the original disconnect function for each account card will be consolidated into the new UI during onboarding? |
@ankitguptaindia this is ready for QA. Note that this is a sub-task of #2509, so the onboarding flow will not be able to be completed until the whole feature is complete.
All of the functionality handled by the separate cards will be handled within the consolidated UI being started in #2566 as part of #2509. |
Engineering complete and approved, moving to UAT for @fblascogarma final approval |
Just tagging @joemcgill and @dsawardekar to advise this needs to be merged please |
Closing this as completed since it was part of the 2.9 release. |
As part of #2509, we will be consolidating the UI for connecting to Google Merchant Center and Google Ads accounts into a unified UI with the
GoogleAccountCard
.To begin this effort, we'll remove the existing
GoogleAdsAccountCard
andGoogleMCAccountCard
components from theSetupAccounts
flow of the onboarding flow.Acceptance Criteria
GoogleMCDisclaimer
is moved to the footer next to the FAQs (see screenshot).Implementation Brief
Note
This work should be branched from feature/2458-streamline-onboarding and a PR should be created against the feature/2458-consolidate-google-account-cards branch.
The
SetupAccounts
component that needs to be edited is here.Test Coverage
Definition Questions
The text was updated successfully, but these errors were encountered: