Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate accounts onboarding: Automatically preselect a Google Ads account when there is only one, as well as adjust the UI presentation #2608

Fix JSDocs.

d8f3ed9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 7, 2024 in 0s

62.7% (+0.0%) compared to 345e6b1

View this Pull Request on Codecov

62.7% (+0.0%) compared to 345e6b1

Details

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.7%. Comparing base (345e6b1) to head (d8f3ed9).

Files with missing lines Patch % Lines
js/src/components/app-select-control/index.js 86.7% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                              Coverage Diff                              @@
##           feature/2509-consolidate-google-account-cards   #2608   +/-   ##
=============================================================================
  Coverage                                           62.7%   62.7%           
=============================================================================
  Files                                                319     319           
  Lines                                               5063    5071    +8     
  Branches                                            1233    1237    +4     
=============================================================================
+ Hits                                                3173    3179    +6     
- Misses                                              1716    1718    +2     
  Partials                                             174     174           
Files with missing lines Coverage Δ
...src/components/ads-account-select-control/index.js 100.0% <100.0%> (ø)
...nents/google-ads-account-card/connect-ads/index.js 96.0% <ø> (ø)
...components/merchant-center-select-control/index.js 100.0% <100.0%> (ø)
js/src/components/app-select-control/index.js 88.2% <86.7%> (-11.8%) ⬇️