Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS ] Add documentation link to floating button #15085

Merged
merged 5 commits into from
Feb 10, 2025

Conversation

iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Feb 6, 2025

Closes: #15050

Description

This PR adds a "View Documentation" link to the floating menu that will redirect the merchant to public facing POS docs. The URL is still a 404, so won't show the public docs.

Screen.Recording.2025-02-06.at.16.56.15.mov

Caveats

The Menu component has heavy limitations based on the system (slack thread: CGPNUU63E/p1738856335664189-slack-CGPNUU63E ), so the text will look properly "cut" under the right screen size, it might not be a one-liner in bigger screen sizes or in different languages. I think we can take the compromise for the moment, and explore if we should create a new component in the future, if worth it.

Testing information

  • Enter in POS
  • Tap the floating ellipsis ...
  • Observe a web view is open with a 404. Adding a breakpoint to the view we can observe that the URL that attempts to open is https://woocommerce.com/document/woo-mobile-app-point-of-sale-mode/

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@iamgabrielma iamgabrielma marked this pull request as ready for review February 6, 2025 16:01
@iamgabrielma iamgabrielma added type: task An internally driven task. feature: POS labels Feb 6, 2025
@iamgabrielma iamgabrielma added this to the 21.8 milestone Feb 6, 2025
@iamgabrielma iamgabrielma requested a review from staskus February 6, 2025 16:04
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 6, 2025

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr15085-b73d7c4
Version21.6
Bundle IDcom.automattic.alpha.woocommerce
Commitb73d7c4
App Center BuildWooCommerce - Prototype Builds #12880
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.


static let viewDocumentation = NSLocalizedString(
"pointOfSale.floatingButtons.viewDocumentation.button.title",
value: "View Documentation",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're changing this string to "Documentation" only. Ref: p1738915805063569?thread_ts=1738652142.617639&cid=C070SJRA8DP-slack-C070SJRA8DP I'll make the change before merging, in case I have to address something else 👍

@staskus
Copy link
Contributor

staskus commented Feb 7, 2025

Expectation: See the documentation
Reality: 1/3 screen is promotion, 1/4 is GDPR

image

Copy link
Contributor

@staskus staskus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 👍 Thanks!

@iamgabrielma iamgabrielma merged commit 7158e89 into trunk Feb 10, 2025
12 checks passed
@iamgabrielma iamgabrielma deleted the task/15050-pos-add-doc-link-to-interface branch February 10, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: POS type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Woo POS] Add a Link to Public-Facing Documentation in POS Interface
3 participants