-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo POS ] Add documentation link to floating button #15085
Conversation
|
|
||
static let viewDocumentation = NSLocalizedString( | ||
"pointOfSale.floatingButtons.viewDocumentation.button.title", | ||
value: "View Documentation", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're changing this string to "Documentation" only. Ref: p1738915805063569?thread_ts=1738652142.617639&cid=C070SJRA8DP-slack-C070SJRA8DP I'll make the change before merging, in case I have to address something else 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great 👍 Thanks!
Closes: #15050
Description
This PR adds a "View Documentation" link to the floating menu that will redirect the merchant to public facing POS docs. The URL is still a 404, so won't show the public docs.
Screen.Recording.2025-02-06.at.16.56.15.mov
Caveats
The
Menu
component has heavy limitations based on the system (slack thread: CGPNUU63E/p1738856335664189-slack-CGPNUU63E ), so the text will look properly "cut" under the right screen size, it might not be a one-liner in bigger screen sizes or in different languages. I think we can take the compromise for the moment, and explore if we should create a new component in the future, if worth it.Testing information
...
https://woocommerce.com/document/woo-mobile-app-point-of-sale-mode/
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: