Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to handle labels that aren't valid paths #458

Open
woodruffw opened this issue Oct 29, 2022 · 2 comments
Open

Figure out how to handle labels that aren't valid paths #458

woodruffw opened this issue Oct 29, 2022 · 2 comments
Assignees
Labels

Comments

@woodruffw
Copy link
Owner

The fact that labels currently need to be valid paths (more precisely, valid base filenames) is a leaky abstraction. A user should be able to label their record with anything (within reason): a URL, slashes, etc.

@woodruffw woodruffw self-assigned this Oct 29, 2022
@woodruffw
Copy link
Owner Author

Right now this will fail with a filesystem error:

$ kbs2 new "test/test"
? Username? foo
? Password? ********
Error: No such file or directory (os error 2)

@woodruffw
Copy link
Owner Author

It's not ideal for diffing, but maybe something like a single binary KV store makes the most sense at this point.

sled is probably a good option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant