[feat/CK-212] 로드맵 생성페이지 오류를 해결한다. #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+10
to
+14
| VERY_EASY: '매우쉬움', | ||
| EASY: '쉬움', | ||
| NORMAL: '보통', | ||
| DIFFICULT: '어려움', | ||
| VERY_DIFFICULT: '매우어려움', |
|
|
||
| export type DifficultyValueType = '매우쉬움' | '쉬움' | '보통' | '어려움' | '매우어려움'; | ||
|
|
||
| export type DifficultiesType = { [key in DifficultyKeyType]: DifficultyValueType }; |
Comment on lines
9
to
10
| if (ref.current === null) return; | ||
| if (ref.current.value === '') return; |
There was a problem hiding this comment.
사소하지만 아래와 같이 단순화할 수 있을 것 같습니다!
if (!ref.current?.value) return;There was a problem hiding this comment.
너무 똑똑해서 화가 다 나네요..
| @@ -27,7 +30,7 @@ export const useCollectRoadmapData = () => { | |||
| })); | |||
There was a problem hiding this comment.
DummyCategoryType가 아직 사용되고 있네요
이제 타입을 수정해줘도 괜찮을 것 같아요!
jw-r
requested changes
Sep 30, 2023
sh981013s
approved these changes
Sep 30, 2023
Comment on lines
+63
to
64
| {getInvariantObjectKeys(invariantOf(Difficulties)).map((difficulty, idx) => { | ||
| return ( |
There was a problem hiding this comment.
getInvariantObjectKeys(invariantOf(Difficulties))[selectedOption] 와 같은 코드가 여러 번 나타나고 있는 것 같아요!.로직을 추가로 별도의 유틸리티 함수로 분리하는 것은 불가능할까요? 😀
There was a problem hiding this comment.
험.... 이미 유틸로 빼져있는 함수라서 이부분은 더 고민해볼께요!!
| @@ -27,7 +30,7 @@ export const useCollectRoadmapData = () => { | |||
| })); | |||
| }; | |||
|
|
|||
| const getSelectedDifficulty = (difficulty: keyof DummyDifficultyType | null) => { | |||
| const getSelectedDifficulty = (difficulty: DifficultyKeyType | null) => { | |||
There was a problem hiding this comment.
getSelectedDifficulty라는 메서드 이름은 "get"이라는 동사를 사용하고 있지만, 실제로는 값을 설정(set)하는 역할을 하는 것처럼 보이는데 네이밍을 바꾸면 어떨까요?? 😀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 작업 이슈 번호
CK-212
✨ 작업 내용
로드맵 생성페이지 오류 해결했습니다.
💬 리뷰어에게 남길 멘트
잘부탁드림당~
🚀 요구사항 분석