From 59a67ce69e561ca7a97c7dcd214cb3d9a7d5c14b Mon Sep 17 00:00:00 2001 From: kyum-q <109158497+kyum-q@users.noreply.github.com> Date: Tue, 15 Oct 2024 16:45:33 +0900 Subject: [PATCH 01/20] =?UTF-8?q?refactor(service):=20TemplateApplicationS?= =?UTF-8?q?ervice.deleteAllByMemberAndTemplateIds=20=EB=84=A4=EC=9D=B4?= =?UTF-8?q?=EB=B0=8D=20=EB=B3=80=EA=B2=BD?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../template/controller/TemplateController.java | 2 +- .../service/facade/TemplateApplicationService.java | 12 ++++++------ .../facade/TemplateApplicationServiceTest.java | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/backend/src/main/java/codezap/template/controller/TemplateController.java b/backend/src/main/java/codezap/template/controller/TemplateController.java index ee150d4fd..eb63c426e 100644 --- a/backend/src/main/java/codezap/template/controller/TemplateController.java +++ b/backend/src/main/java/codezap/template/controller/TemplateController.java @@ -109,7 +109,7 @@ public ResponseEntity deleteTemplates( @AuthenticationPrinciple Member member, @PathVariable List ids ) { - templateApplicationService.deleteByMemberAndIds(member, ids); + templateApplicationService.deleteAllByMemberAndTemplateIds(member, ids); return ResponseEntity.noContent().build(); } } diff --git a/backend/src/main/java/codezap/template/service/facade/TemplateApplicationService.java b/backend/src/main/java/codezap/template/service/facade/TemplateApplicationService.java index 813298ba6..284c006ee 100644 --- a/backend/src/main/java/codezap/template/service/facade/TemplateApplicationService.java +++ b/backend/src/main/java/codezap/template/service/facade/TemplateApplicationService.java @@ -144,11 +144,11 @@ public void update(Member member, Long templateId, UpdateTemplateRequest updateT } @Transactional - public void deleteByMemberAndIds(Member member, List ids) { - thumbnailService.deleteByTemplateIds(ids); - sourceCodeService.deleteByTemplateIds(ids); - tagService.deleteAllByTemplateIds(ids); - likesService.deleteAllByTemplateIds(ids); - templateService.deleteByMemberAndIds(member, ids); + public void deleteAllByMemberAndTemplateIds(Member member, List templateIds) { + thumbnailService.deleteByTemplateIds(templateIds); + sourceCodeService.deleteByTemplateIds(templateIds); + tagService.deleteAllByTemplateIds(templateIds); + likesService.deleteAllByTemplateIds(templateIds); + templateService.deleteByMemberAndIds(member, templateIds); } } diff --git a/backend/src/test/java/codezap/template/service/facade/TemplateApplicationServiceTest.java b/backend/src/test/java/codezap/template/service/facade/TemplateApplicationServiceTest.java index aea5b3795..e35e3a6d9 100644 --- a/backend/src/test/java/codezap/template/service/facade/TemplateApplicationServiceTest.java +++ b/backend/src/test/java/codezap/template/service/facade/TemplateApplicationServiceTest.java @@ -426,7 +426,7 @@ void deleteByMemberAndIds() { var deleteIds = List.of(template1.getId(), template2.getId()); // when - sut.deleteByMemberAndIds(member, deleteIds); + sut.deleteAllByMemberAndTemplateIds(member, deleteIds); // then Specification