refactor-fe: Tab 컴포넌트 수정 #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
1727069629.005379 |
|
1727069637.599449 |
llqqssttyy
approved these changes
Sep 23, 2024
Comment on lines
58
to
60
| if (index !== choices.length - 1) { | ||
| inputRefs.current[index + 1]?.focus(); | ||
| } |
There was a problem hiding this comment.
마지막 Input이 아닐 때 엔터가 입력될 경우 다음 input으로 포커스가 이동하는 기능이 추가됐네요.👍
이건 그냥 취향 차이인 것 같은데, early return을 사용하는 경우가 아니니 그냥 if-else문으로 연결하는 것도 좋을 것 같습니다.
조건을 1번만 이해해도 된다면 코드가 더 쉽게 읽히니까요 :)
꼭 고칠 필요는 없으니 자유롭게 반영해 주세요!
| @@ -51,17 +61,14 @@ const TabButton = styled.button<{ isActive: boolean }>` | |||
| } | |||
| `; | |||
|
|
|||
| const TabPanel = styled.div<{ isVisible: boolean }>` | |||
seongjinme
approved these changes
Sep 24, 2024
Comment on lines
-61
to
+71
| transition: transform 0.2s ease-in-out; | ||
| transform: translateY(${({ isVisible }) => (isVisible ? '0' : '1rem')}); | ||
|
|
||
| ${({ isVisible }) => (isVisible ? visibleStyles : hiddenStyles)}; | ||
| animation: ${showUp} 0.2s ease-in-out; |
There was a problem hiding this comment.
keyframes를 이용한 translateY 애니메이션으로 깔끔하게 정리되었네요 👍
| return <S.TabPanel isVisible={isVisible}>{children}</S.TabPanel>; | ||
| return isVisible && <S.TabPanel>{children}</S.TabPanel>; |
llqqssttyy
pushed a commit
that referenced
this pull request
Sep 27, 2024
Co-authored-by: Jeongwoo Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue description
목적
작업 세부사항
참고 사항
TAB_ANIMATE
closes #679