From ce2dfc60107ee16d2e7ea5d009bc656e61e1fe43 Mon Sep 17 00:00:00 2001 From: nayonsoso Date: Sun, 11 Aug 2024 05:48:47 +0900 Subject: [PATCH] =?UTF-8?q?style:=20=EA=B0=9C=ED=96=89=20=EB=B0=8F=20?= =?UTF-8?q?=EC=BD=94=EB=93=9C=20=EC=9E=AC=EC=A0=95=EB=A0=AC?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../review/dto/request/create/CreateReviewRequest.java | 4 ++-- .../service/CreateCheckBoxAnswerRequestValidator.java | 2 +- .../review/service/CreateTextAnswerRequestValidator.java | 2 +- ...heckBoxAnswerIncludedNotProvidedOptionItemException.java | 3 ++- ...bmittedQuestionAndProvidedQuestionMismatchException.java | 6 ++++-- .../src/main/java/reviewme/template/domain/Template.java | 1 + .../reviewme/review/repository/ReviewRepositoryTest.java | 2 +- .../service/CreateCheckBoxAnswerRequestValidatorTest.java | 2 +- 8 files changed, 13 insertions(+), 9 deletions(-) diff --git a/backend/src/main/java/reviewme/review/dto/request/create/CreateReviewRequest.java b/backend/src/main/java/reviewme/review/dto/request/create/CreateReviewRequest.java index 736cb0fd1..7c0fc347d 100644 --- a/backend/src/main/java/reviewme/review/dto/request/create/CreateReviewRequest.java +++ b/backend/src/main/java/reviewme/review/dto/request/create/CreateReviewRequest.java @@ -2,8 +2,8 @@ import java.util.List; -public record CreateReviewRequest ( +public record CreateReviewRequest( String reviewRequestCode, List answers -){ +) { } diff --git a/backend/src/main/java/reviewme/review/service/CreateCheckBoxAnswerRequestValidator.java b/backend/src/main/java/reviewme/review/service/CreateCheckBoxAnswerRequestValidator.java index bb6e6531b..b8456b14b 100644 --- a/backend/src/main/java/reviewme/review/service/CreateCheckBoxAnswerRequestValidator.java +++ b/backend/src/main/java/reviewme/review/service/CreateCheckBoxAnswerRequestValidator.java @@ -9,10 +9,10 @@ import reviewme.question.domain.Question2; import reviewme.question.repository.Question2Repository; import reviewme.review.dto.request.create.CreateReviewAnswerRequest; -import reviewme.review.service.exception.SelectedCheckBoxAnswerCountOutOfRange; import reviewme.review.service.exception.CheckBoxAnswerIncludedNotProvidedOptionItemException; import reviewme.review.service.exception.CheckBoxAnswerIncludedTextException; import reviewme.review.service.exception.RequiredQuestionMustBeAnsweredException; +import reviewme.review.service.exception.SelectedCheckBoxAnswerCountOutOfRange; import reviewme.template.domain.exception.OptionGroupNotFoundException; import reviewme.template.repository.OptionGroupRepository; import reviewme.template.repository.OptionItemRepository; diff --git a/backend/src/main/java/reviewme/review/service/CreateTextAnswerRequestValidator.java b/backend/src/main/java/reviewme/review/service/CreateTextAnswerRequestValidator.java index dce6f26f1..4e4bab14d 100644 --- a/backend/src/main/java/reviewme/review/service/CreateTextAnswerRequestValidator.java +++ b/backend/src/main/java/reviewme/review/service/CreateTextAnswerRequestValidator.java @@ -20,7 +20,7 @@ public void validate(CreateReviewAnswerRequest request) { validateQuestionRequired(question, request); } - private static void validateNotIncludingOptions(CreateReviewAnswerRequest request) { + private void validateNotIncludingOptions(CreateReviewAnswerRequest request) { if (request.selectedOptionIds() != null) { throw new TextAnswerIncudedOptionException(); } diff --git a/backend/src/main/java/reviewme/review/service/exception/CheckBoxAnswerIncludedNotProvidedOptionItemException.java b/backend/src/main/java/reviewme/review/service/exception/CheckBoxAnswerIncludedNotProvidedOptionItemException.java index 6f5ac6835..50696ae9d 100644 --- a/backend/src/main/java/reviewme/review/service/exception/CheckBoxAnswerIncludedNotProvidedOptionItemException.java +++ b/backend/src/main/java/reviewme/review/service/exception/CheckBoxAnswerIncludedNotProvidedOptionItemException.java @@ -7,7 +7,8 @@ @Slf4j public class CheckBoxAnswerIncludedNotProvidedOptionItemException extends BadRequestException { - public CheckBoxAnswerIncludedNotProvidedOptionItemException(List providedOptionIds, List submittedOptionIds) { + public CheckBoxAnswerIncludedNotProvidedOptionItemException(List providedOptionIds, + List submittedOptionIds) { super("제공되는 선택지에 없는 선택지를 응답했어요."); log.info("Answer included not provided options - providedOptionIds: {}, submittedOptionIds: {}", providedOptionIds, submittedOptionIds); diff --git a/backend/src/main/java/reviewme/review/service/exception/SubmittedQuestionAndProvidedQuestionMismatchException.java b/backend/src/main/java/reviewme/review/service/exception/SubmittedQuestionAndProvidedQuestionMismatchException.java index 6a74aa582..0434fff2e 100644 --- a/backend/src/main/java/reviewme/review/service/exception/SubmittedQuestionAndProvidedQuestionMismatchException.java +++ b/backend/src/main/java/reviewme/review/service/exception/SubmittedQuestionAndProvidedQuestionMismatchException.java @@ -7,9 +7,11 @@ @Slf4j public class SubmittedQuestionAndProvidedQuestionMismatchException extends BadRequestException { - public SubmittedQuestionAndProvidedQuestionMismatchException(List submittedQuestionIds, List providedQuestionIds) { + public SubmittedQuestionAndProvidedQuestionMismatchException(List submittedQuestionIds, + List providedQuestionIds) { super("제출된 응답이 제공된 질문과 매칭되지 않아요."); - log.info("Submitted questions mismatch with provided questions - submittedQuestionIds: {}, providedQuestionIds: {}", + log.info( + "Submitted questions mismatch with provided questions - submittedQuestionIds: {}, providedQuestionIds: {}", submittedQuestionIds, providedQuestionIds); } } diff --git a/backend/src/main/java/reviewme/template/domain/Template.java b/backend/src/main/java/reviewme/template/domain/Template.java index b15372d8e..3a8c733b1 100644 --- a/backend/src/main/java/reviewme/template/domain/Template.java +++ b/backend/src/main/java/reviewme/template/domain/Template.java @@ -18,6 +18,7 @@ @NoArgsConstructor(access = AccessLevel.PROTECTED) @Getter public class Template { + @Id @GeneratedValue(strategy = GenerationType.IDENTITY) private Long id; diff --git a/backend/src/test/java/reviewme/review/repository/ReviewRepositoryTest.java b/backend/src/test/java/reviewme/review/repository/ReviewRepositoryTest.java index 7b8adda28..517707082 100644 --- a/backend/src/test/java/reviewme/review/repository/ReviewRepositoryTest.java +++ b/backend/src/test/java/reviewme/review/repository/ReviewRepositoryTest.java @@ -28,6 +28,6 @@ class ReviewRepositoryTest { // then assertThat(actual).map(Review::getId) - .containsExactly(review4.getId(), review2.getId(), review1.getId(), review3.getId()); + .containsExactly(review4.getId(), review2.getId(), review1.getId(), review3.getId()); } } diff --git a/backend/src/test/java/reviewme/review/service/CreateCheckBoxAnswerRequestValidatorTest.java b/backend/src/test/java/reviewme/review/service/CreateCheckBoxAnswerRequestValidatorTest.java index 55e00a08b..ca705fb20 100644 --- a/backend/src/test/java/reviewme/review/service/CreateCheckBoxAnswerRequestValidatorTest.java +++ b/backend/src/test/java/reviewme/review/service/CreateCheckBoxAnswerRequestValidatorTest.java @@ -15,8 +15,8 @@ import reviewme.review.dto.request.create.CreateReviewAnswerRequest; import reviewme.review.service.exception.CheckBoxAnswerIncludedNotProvidedOptionItemException; import reviewme.review.service.exception.CheckBoxAnswerIncludedTextException; -import reviewme.review.service.exception.SelectedCheckBoxAnswerCountOutOfRange; import reviewme.review.service.exception.RequiredQuestionMustBeAnsweredException; +import reviewme.review.service.exception.SelectedCheckBoxAnswerCountOutOfRange; import reviewme.support.ServiceTest; import reviewme.template.domain.exception.OptionGroupNotFoundException; import reviewme.template.repository.OptionGroupRepository;