From 73dd678d1f01995f6c46b587885e8795cd54ebd4 Mon Sep 17 00:00:00 2001
From: hodu <92203597+Junyoung-WON@users.noreply.github.com>
Date: Mon, 14 Oct 2024 21:53:08 +0900
Subject: [PATCH] =?UTF-8?q?refactor:=20=EB=A6=AC=EC=86=8C=EC=8A=A4=20?=
=?UTF-8?q?=EB=A6=AC=ED=8C=A9=ED=84=B0=EB=A7=81=20=EB=B0=8F=20xml=20?=
=?UTF-8?q?=EC=BB=A8=EB=B2=A4=EC=85=98=20=EC=A0=81=EC=9A=A9=20#473=20(#478?=
=?UTF-8?q?)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
* refactor: View 별 스타일 분리 및 세분화
- 너무 많은 스타일을 가지고 있는 View 의 경우 따로 파일을 생성하여 분리
- 연관성 있는 View style 끼리 정렬
- 주석으로 View 별 스타일 구분
- 스타일 추가 및 세분화
* refactor: 사용하지 않는 layout 제거
- Google Map Fragment 레이아웃과 방문기록(현 스타카토) 레이아웃 제거
* refactor: 상세 페이지 Toolbar의 레이아웃을 include
- 기존에 사용하던 toolbar_detail 의 레이아웃을 include 태그로 적용
* refactor: NavigationToolbar 의 paddingEnd 속성을 style에 지정
* refactor: ConstraintLayout 리팩터링
- ConstraintLayout 내부 View 들의 match_parent 속성을 0dp 로 변경하고 constraint 설정
- 중첩된 ConstraintLayout 제거
* refactor: 기분 선택 리사이클러뷰의 padding 속성 수정
* refactor: 이미지 contentDescription 설정 및 lint 설정
* refactor: xml layout 의 ID 네이밍 컨벤션 적용
- 누락된 이미지 contentDescription 설정
* fix: 스타카토 조회 화면에서 사용하는 Toolbar로 롤백
- 수정, 삭제 시 Memory의 ID가 필요하기 때문에 기존에 사용하는 Toolbar 와 동작이 다름
* ui: 추억 소개 InputText 의 크기 축소 및 여백 너비 조정
* refactor: TextInput style의 이름 변경
- TextInputEditTextStyle.OneLine -> TextInputEditTextStyle.SingleLine
* refactor: View 에서 MaterialDivider 로 변경
* refactor: MaterialDivider View의 id명 변경 및 divider 색상 속성 변경
- view_timeline_line -> divider_timeline
- foreground -> dividerColor
---
.../src/main/res/layout/activity_login.xml | 3 +-
.../app/src/main/res/layout/activity_main.xml | 3 +-
.../res/layout/activity_memory_creation.xml | 8 +-
.../res/layout/activity_memory_update.xml | 8 +-
.../src/main/res/layout/activity_mypage.xml | 14 +-
.../src/main/res/layout/activity_recovery.xml | 103 +++++----
.../res/layout/activity_visit_creation.xml | 9 +-
.../main/res/layout/activity_visit_update.xml | 11 +-
.../fragment_delete_impossibility_dialog.xml | 4 +-
.../app/src/main/res/layout/fragment_maps.xml | 8 -
.../src/main/res/layout/fragment_moment.xml | 7 +-
.../res/layout/fragment_moment_comments.xml | 77 +++----
.../fragment_moment_feeling_selection.xml | 2 +-
.../src/main/res/layout/fragment_visit.xml | 43 ----
.../res/layout/item_moment_my_comment.xml | 17 +-
.../res/layout/item_moment_others_comment.xml | 17 +-
.../main/res/layout/item_viewpage_photo.xml | 2 +-
.../main/res/layout/layout_photo_attach.xml | 5 +-
.../src/main/res/layout/layout_timeline.xml | 21 +-
.../src/main/res/layout/toolbar_detail.xml | 3 +-
.../app/src/main/res/values/styles.xml | 217 +++---------------
.../app/src/main/res/values/styles_button.xml | 93 ++++++++
.../src/main/res/values/styles_comment.xml | 41 ++++
.../src/main/res/values/styles_text_input.xml | 46 ++++
.../src/main/res/values/styles_toolbar.xml | 38 +++
25 files changed, 390 insertions(+), 410 deletions(-)
delete mode 100644 android/Staccato_AN/app/src/main/res/layout/fragment_maps.xml
delete mode 100644 android/Staccato_AN/app/src/main/res/layout/fragment_visit.xml
create mode 100644 android/Staccato_AN/app/src/main/res/values/styles_button.xml
create mode 100644 android/Staccato_AN/app/src/main/res/values/styles_comment.xml
create mode 100644 android/Staccato_AN/app/src/main/res/values/styles_text_input.xml
create mode 100644 android/Staccato_AN/app/src/main/res/values/styles_toolbar.xml
diff --git a/android/Staccato_AN/app/src/main/res/layout/activity_login.xml b/android/Staccato_AN/app/src/main/res/layout/activity_login.xml
index 33b35af49..b816ee3c6 100644
--- a/android/Staccato_AN/app/src/main/res/layout/activity_login.xml
+++ b/android/Staccato_AN/app/src/main/res/layout/activity_login.xml
@@ -58,8 +58,7 @@
app:layout_constraintTop_toBottomOf="@id/space_login_separating_logo_and_nickname_et">
diff --git a/android/Staccato_AN/app/src/main/res/layout/activity_memory_creation.xml b/android/Staccato_AN/app/src/main/res/layout/activity_memory_creation.xml
index d42b1bb9e..bf1cbd38e 100644
--- a/android/Staccato_AN/app/src/main/res/layout/activity_memory_creation.xml
+++ b/android/Staccato_AN/app/src/main/res/layout/activity_memory_creation.xml
@@ -25,7 +25,7 @@
@@ -172,7 +170,7 @@
android:id="@+id/tv_memory_creation_period_title"
style="@style/SubTitleStyle"
android:layout_marginStart="24dp"
- android:layout_marginTop="24dp"
+ android:layout_marginTop="40dp"
android:text="@string/memory_creation_period_setting"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toBottomOf="@id/text_input_memory_creation_description" />
diff --git a/android/Staccato_AN/app/src/main/res/layout/activity_memory_update.xml b/android/Staccato_AN/app/src/main/res/layout/activity_memory_update.xml
index dab0ca439..c80a8e4c7 100644
--- a/android/Staccato_AN/app/src/main/res/layout/activity_memory_update.xml
+++ b/android/Staccato_AN/app/src/main/res/layout/activity_memory_update.xml
@@ -25,7 +25,7 @@
@@ -173,7 +171,7 @@
android:id="@+id/tv_memory_update_period_title"
style="@style/SubTitleStyle"
android:layout_marginStart="24dp"
- android:layout_marginTop="24dp"
+ android:layout_marginTop="40dp"
android:text="@string/memory_creation_period_setting"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toBottomOf="@id/text_input_memory_update_description" />
diff --git a/android/Staccato_AN/app/src/main/res/layout/activity_mypage.xml b/android/Staccato_AN/app/src/main/res/layout/activity_mypage.xml
index a8679fa3e..2dc3f1dae 100644
--- a/android/Staccato_AN/app/src/main/res/layout/activity_mypage.xml
+++ b/android/Staccato_AN/app/src/main/res/layout/activity_mypage.xml
@@ -26,7 +26,7 @@
+ bind:coilPlaceHolder="@{@drawable/icon_member}"
+ tools:src="@drawable/icon_member" />
+ app:layout_constraintEnd_toEndOf="parent"
+ app:layout_constraintStart_toStartOf="parent"
+ app:layout_constraintTop_toBottomOf="@+id/frame_mypage_profile_image"
+ tools:text="사용자 닉네임" />
-
+ android:orientation="vertical"
+ app:layout_constraintGuide_begin="24dp" />
-
+
-
+
-
+
+
+
+
+ android:text="@={viewModel.recoveryCode}" />
-
+
-
+
diff --git a/android/Staccato_AN/app/src/main/res/layout/activity_visit_creation.xml b/android/Staccato_AN/app/src/main/res/layout/activity_visit_creation.xml
index f9313e3a5..5be4a9605 100644
--- a/android/Staccato_AN/app/src/main/res/layout/activity_visit_creation.xml
+++ b/android/Staccato_AN/app/src/main/res/layout/activity_visit_creation.xml
@@ -28,10 +28,7 @@
diff --git a/android/Staccato_AN/app/src/main/res/layout/fragment_delete_impossibility_dialog.xml b/android/Staccato_AN/app/src/main/res/layout/fragment_delete_impossibility_dialog.xml
index e4b81a728..29a5e0fdc 100644
--- a/android/Staccato_AN/app/src/main/res/layout/fragment_delete_impossibility_dialog.xml
+++ b/android/Staccato_AN/app/src/main/res/layout/fragment_delete_impossibility_dialog.xml
@@ -6,9 +6,7 @@
-
+
-
\ No newline at end of file
diff --git a/android/Staccato_AN/app/src/main/res/layout/fragment_moment.xml b/android/Staccato_AN/app/src/main/res/layout/fragment_moment.xml
index 8ef78af42..0d254ecb0 100644
--- a/android/Staccato_AN/app/src/main/res/layout/fragment_moment.xml
+++ b/android/Staccato_AN/app/src/main/res/layout/fragment_moment.xml
@@ -26,8 +26,7 @@
@@ -153,7 +152,7 @@
-
-
-
+ app:layout_constraintEnd_toStartOf="@id/iv_moment_comments_send"
+ app:layout_constraintStart_toStartOf="parent" />
-
-
-
-
-
+
diff --git a/android/Staccato_AN/app/src/main/res/layout/fragment_moment_feeling_selection.xml b/android/Staccato_AN/app/src/main/res/layout/fragment_moment_feeling_selection.xml
index 7b59883ed..38b0f8c8e 100644
--- a/android/Staccato_AN/app/src/main/res/layout/fragment_moment_feeling_selection.xml
+++ b/android/Staccato_AN/app/src/main/res/layout/fragment_moment_feeling_selection.xml
@@ -30,7 +30,7 @@
android:nestedScrollingEnabled="false"
android:orientation="horizontal"
android:overScrollMode="never"
- android:paddingStart="13dp"
+ android:paddingHorizontal="13dp"
app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
diff --git a/android/Staccato_AN/app/src/main/res/layout/fragment_visit.xml b/android/Staccato_AN/app/src/main/res/layout/fragment_visit.xml
deleted file mode 100644
index 5659f87ad..000000000
--- a/android/Staccato_AN/app/src/main/res/layout/fragment_visit.xml
+++ /dev/null
@@ -1,43 +0,0 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
diff --git a/android/Staccato_AN/app/src/main/res/layout/item_moment_my_comment.xml b/android/Staccato_AN/app/src/main/res/layout/item_moment_my_comment.xml
index 405999ee3..0f138aee1 100644
--- a/android/Staccato_AN/app/src/main/res/layout/item_moment_my_comment.xml
+++ b/android/Staccato_AN/app/src/main/res/layout/item_moment_my_comment.xml
@@ -18,12 +18,8 @@
+ app:layout_constraintTop_toTopOf="parent"
+ app:tint="@color/gray4" />
-
+ style="@style/NavigationToolbarStyle">
-
-
-
-
-
+
-
+
-
-
-
-
-
-
+
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/android/Staccato_AN/app/src/main/res/values/styles_comment.xml b/android/Staccato_AN/app/src/main/res/values/styles_comment.xml
new file mode 100644
index 000000000..ea8f971ac
--- /dev/null
+++ b/android/Staccato_AN/app/src/main/res/values/styles_comment.xml
@@ -0,0 +1,41 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/android/Staccato_AN/app/src/main/res/values/styles_text_input.xml b/android/Staccato_AN/app/src/main/res/values/styles_text_input.xml
new file mode 100644
index 000000000..ef4502cbc
--- /dev/null
+++ b/android/Staccato_AN/app/src/main/res/values/styles_text_input.xml
@@ -0,0 +1,46 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
diff --git a/android/Staccato_AN/app/src/main/res/values/styles_toolbar.xml b/android/Staccato_AN/app/src/main/res/values/styles_toolbar.xml
new file mode 100644
index 000000000..7afdb9b71
--- /dev/null
+++ b/android/Staccato_AN/app/src/main/res/values/styles_toolbar.xml
@@ -0,0 +1,38 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+