Internal: Update rs library version #22332
Merged
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Generated by 🚫 Danger |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the wordpress-rs library dependency to a newer version and adapts the media upload API call to match the new library interface. The key change is restructuring how parameters are passed to the media creation endpoint.
- Updated
wordpress-rslibrary version fromtrunk-a0864c91b8dc3726b0ad43e22662c4415aca59cetotrunk-fb107b497caaf2b1f4ffcf9f487784792561a645 - Refactored
MediaCreateParamsconstruction to includefilePathwithin the params object instead of as a separate parameter - Removed
fileContentTypeandrequestIdparameters from the media creation call
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gradle/libs.versions.toml | Updates the wordpress-rs library version to the latest trunk commit |
| libs/fluxc/src/main/java/org/wordpress/android/fluxc/network/rest/wpapi/media/MediaRSApiRestClient.kt | Refactors the media upload call to use the new API signature, moving filePath into MediaCreateParams and removing fileContentType and requestId parameters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...c/src/main/java/org/wordpress/android/fluxc/network/rest/wpapi/media/MediaRSApiRestClient.kt
Show resolved
Hide resolved
|
Contributor
Project dependencies changeslist! Upgraded Dependencies
rs.wordpress.api:android:trunk-fb107b497caaf2b1f4ffcf9f487784792561a645, (changed from trunk-a0864c91b8dc3726b0ad43e22662c4415aca59ce)
rs.wordpress.api:kotlin:trunk-fb107b497caaf2b1f4ffcf9f487784792561a645, (changed from trunk-a0864c91b8dc3726b0ad43e22662c4415aca59ce)tree +--- project :libs:fluxc
-| \--- rs.wordpress.api:android:trunk-a0864c91b8dc3726b0ad43e22662c4415aca59ce
-| +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.2.1 (*)
-| +--- com.squareup.okhttp3:okhttp-tls:4.12.0
-| | +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.2.1 (*)
-| | +--- com.squareup.okio:okio:3.6.0 -> 3.16.1 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.24 (*)
-| +--- net.java.dev.jna:jna:5.18.1
-| +--- rs.wordpress.api:kotlin:trunk-a0864c91b8dc3726b0ad43e22662c4415aca59ce
-| | +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.2.1 (*)
-| | +--- com.squareup.okhttp3:okhttp-tls:4.12.0 (*)
-| | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.20 (*)
-| \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.20 (*)
+| \--- rs.wordpress.api:android:trunk-fb107b497caaf2b1f4ffcf9f487784792561a645
+| +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.2.1 (*)
+| +--- com.squareup.okhttp3:okhttp-tls:4.12.0
+| | +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.2.1 (*)
+| | +--- com.squareup.okio:okio:3.6.0 -> 3.16.1 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.24 (*)
+| +--- net.java.dev.jna:jna:5.18.1
+| +--- rs.wordpress.api:kotlin:trunk-fb107b497caaf2b1f4ffcf9f487784792561a645
+| | +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.2.1 (*)
+| | +--- com.squareup.okhttp3:okhttp-tls:4.12.0 (*)
+| | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.20 (*)
-\--- rs.wordpress.api:android:trunk-a0864c91b8dc3726b0ad43e22662c4415aca59ce (*)
+\--- rs.wordpress.api:android:trunk-fb107b497caaf2b1f4ffcf9f487784792561a645 (*) |
jkmassel
approved these changes
Oct 31, 2025
Contributor
|
| App Name | WordPress | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22332-1391d44 | |
| Commit | 1391d44 | |
| Direct Download | wordpress-prototype-build-pr22332-1391d44.apk |
Contributor
|
| App Name | Jetpack | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22332-1391d44 | |
| Commit | 1391d44 | |
| Direct Download | jetpack-prototype-build-pr22332-1391d44.apk |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #22332 +/- ##
=======================================
Coverage 39.33% 39.33%
=======================================
Files 2198 2198
Lines 105394 105393 -1
Branches 14983 14982 -1
=======================================
Hits 41460 41460
+ Misses 60442 60441 -1
Partials 3492 3492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is just updating the RS library version
Testing instructions