Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSMallocException: Failed to grow buffer #14178

Closed
loremattei opened this issue May 25, 2020 · 12 comments
Closed

NSMallocException: Failed to grow buffer #14178

loremattei opened this issue May 25, 2020 · 12 comments

Comments

@loremattei
Copy link
Contributor

Sentry Url: https://sentry.io/share/issue/f9e98652222541a4b2680cb4345dc8f0/
User Count: 95
Count: 378
First Release: 14.7.0.3
First Seen: 2020-05-05T07:43:36Z
Last Seen: 2020-05-25T05:03:33Z
24 Hours: 7
30 Days: 371

NSMallocException: Failed to grow buffer
  File "UIImage+AlamofireImage.swift", line 103, in UIImage.af_inflate
  File "Request+AlamofireImage.swift", line 204, in DataRequest.image
  File "Request+AlamofireImage.swift", line 96, in DataRequest.imageResponseSerializer
  File "<compiler-generated>", line null, in @callee_guaranteed
  File "ResponseSerialization.swift", line 150, in DataRequest.response<T>
  File "<compiler-generated>", line null, in @callee_guaranteed
...
(22 additional frame(s) were not displayed)
@bummytime
Copy link
Member

A handful of AF Image malloc exceptions centered around ReaderDetailViewController starting on May 5th. @yaelirub could this be related to Private atomic support in #13770?

@yaelirub
Copy link
Contributor

@bummytime , since AFImage framework was added during private Atomic it could be related. Will investigate

@yaelirub
Copy link
Contributor

Priority high as it is a new crash

@yaelirub
Copy link
Contributor

yaelirub commented May 27, 2020

Updating status here:
This is a known issue (since 2018) in AlamofireImage. It happens when trying to inflate images with really large sizes. They recommend a workaround here

Updating the priority to low since if you try to load an image that is large than you app can handle, it's going to crash, the stack trace for these crashes shows memory warning and this issue has been flagged by AFI as low priority.

@bummytime
Copy link
Member

@yaelirub thanks for the update. Out of curiosity, were you able to quantify what a large image is?

@yaelirub
Copy link
Contributor

@bummytime , I was not. I was however able to see multiple memory warnings in the events

@designsimply
Copy link
Contributor

Events in the last 90d: 398
Events in the last 11d for 14.9: zero in 14.9 since it was released on 2020-06-01
Users affected in the last 90d: 100
https://sentry.io/share/issue/f9e98652222541a4b2680cb4345dc8f0/

I noticed the crash for this specific issue has come and gone:

Screen Shot 2020-06-12 at Jun 12 7 59 27 PM

There is another one that seems to have come up in it's place, but the numbers of crashes are still pretty low:

Events in the last 90d: 98
Events in the last 11d for 14.9: 10 in 14.9 since it was released on 2020-06-01
Users affected in the last 90d: 34
https://sentry.io/share/issue/14014cc5a0b34630bf23a7a466d687f9/

90-day graph for issue.id:1695131933:

Screen Shot 2020-06-12 at Jun 12 8 02 11 PM

@yaelirub is it still worth keeping this GitHub issue open for this crash?

@yaelirub
Copy link
Contributor

Probably not @designsimply

@designsimply
Copy link
Contributor

Decided to keep this one open to explore the workaround because the issue is related to media uploads which are an important part of the app experience even though we're currently seeing low volume and it's a known issue in AlamofireImage and has been flagged by AFI as low priority. We can close it later if it's deemed not worth the effort to try the workaround but I am hoping someone with experience managing media in our apps can help give a 2nd opinion.

Events in the last 90d: 385
Users affected in the last 90d: 126
WORDPRESS-IOS-37XR: https://sentry.io/share/issue/14014cc5a0b34630bf23a7a466d687f9/

image

(also see internal reference: pbArwn-Lo-p2)

@designsimply
Copy link
Contributor

Low numbers are holding steady for this one.

Events in the last 90d: 312
Users affected in the last 90d: 86
WORDPRESS-IOS-37XR: https://sentry.io/share/issue/14014cc5a0b34630bf23a7a466d687f9/

image

@designsimply
Copy link
Contributor

Checked the numbers again and there are no recorded cases past v15.9 but we're still seeing a few crashes in 15.9 and below.

WORDPRESS-IOS-37XR: https://sentry.io/share/issue/14014cc5a0b34630bf23a7a466d687f9/

image

Copy link

sentry-io bot commented Dec 20, 2023

Sentry issue: JETPACK-IOS-JC

@kean kean closed this as completed Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants