Adds session helpers #384
Merged
Adds session helpers #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgd
reviewed
Nov 22, 2024
mattgd
reviewed
Nov 26, 2024
mattgd
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Looks good, thanks! There's still two outstanding comments regarding List vs. Sequence in /types/user_management/session.py, but nothing new from second pass.
mattgd
reviewed
Dec 2, 2024
workos/session.py
Outdated
Comment on lines
175
to
196
| def is_valid_jwt(self, token: str) -> bool: | ||
| try: | ||
| signing_key = self.jwks.get_signing_key_from_jwt(token) | ||
| jwt.decode(token, signing_key.key, algorithms=self.jwk_algorithms) | ||
| return True | ||
| except jwt.exceptions.InvalidTokenError: | ||
| return False | ||
|
|
||
| @staticmethod | ||
| def seal_data(data: Dict[str, Any], key: str) -> str: | ||
| fernet = Fernet(key) | ||
| # Encrypt and convert bytes to string | ||
| encrypted_bytes = fernet.encrypt(json.dumps(data).encode()) | ||
| return encrypted_bytes.decode("utf-8") | ||
|
|
||
| @staticmethod | ||
| def unseal_data(sealed_data: str, key: str) -> Dict[str, Any]: | ||
| fernet = Fernet(key) | ||
| # Convert string back to bytes before decryption | ||
| encrypted_bytes = sealed_data.encode("utf-8") | ||
| decrypted_str = fernet.decrypt(encrypted_bytes).decode() | ||
| return cast(Dict[str, Any], json.loads(decrypted_str)) |
There was a problem hiding this comment.
If these are all private, we may want to mark them with a _ prefix.
There was a problem hiding this comment.
They're not really private since they can still be accessed statically. Should we still add the prefix?
There was a problem hiding this comment.
Good question, up to you. "Private" is really just a suggestion anyway. It has no real encapsulation benefits in Python. is_valid_jwt could at least use it though. More-so just helps us so we can consider these methods internal if we need to update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #350
Description
Adds new session helpers. Example API:
Also makes it so dependencies are loaded from
requirements.txtrather than hardcoded insetup.py.Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.