Test Doesn't Recognize Syntactically Different Idiomatic 'Error First' Pattern on 'Make It Modular'

[manavm1990]

Below, kindly see My Solution and LMK what is the issue with this one in comparison to 'Official' Solution. They seem very similar. 😖

My Solution

'make-it-modular.js'

const filterFiles = require("./mymodule");

const [_, __, dir, ext] = process.argv;

filterFiles(dir, ext, (err, files) => {
  if (err) {
    return console.error(err);
  }

  return files.forEach((file) => {
    console.info(file);
  });
});

'mymodule.js'

const { readdir } = require("fs");
const { extname } = require("path");

module.exports = (dir, ext, cb) => {
  readdir(dir, (err, files) => {
    if (err) {
      return cb(err);
    }

    return cb(
      null,
      files.filter((file) => extname(file) === `.${ext}`)
    );
  });
};

✓

 Submission results match expected

 ✓

 Additional module file exports a single function

 ✓

 Additional module file exports a function that takes 3 arguments

 ✗

 Your additional module file [mymodule.js] does not appear to pass back an
 error received from fs.readdir(). Use the following idiomatic Node.js
 pattern inside your callback to fs.readdir(): if (err) return
 callback(err)

'Official' Solution

 Here's the official solution in case you want to compare notes:

─────────────────────────────────────────────────────────────────────────────
 _/usr/local/lib/node_modules/learnyounode/exercises/make_it_modular/soluti
 on/solution.js_ :


    'use strict'
    const filterFn = require('./solution_filter.js')
    const dir = process.argv[2]
    const filterStr = process.argv[3]

    filterFn(dir, filterStr, function (err, list) {
      if (err) {
        return console.error('There was an error:', err)
      }

      list.forEach(function (file) {
        console.log(file)
      })
    })

─────────────────────────────────────────────────────────────────────────────
 _/usr/local/lib/node_modules/learnyounode/exercises/make_it_modular/soluti
 on/solution_filter.js_ :


    'use strict'
    const fs = require('fs')
    const path = require('path')

    module.exports = function (dir, filterStr, callback) {
      fs.readdir(dir, function (err, list) {
        if (err) {
          return callback(err)
        }

        list = list.filter(function (file) {
          return path.extname(file) === '.' + filterStr
        })

        callback(null, list)
      })
    }

[manavm1990]

Duplicate of 700 ✅