implement WorldApp global var check #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
igorosip0v
force-pushed
the
versions-verify
branch
from
b2c9431
to
a5a8338
Compare
andy-t-wang
reviewed
May 30, 2024
andy-t-wang
approved these changes
May 30, 2024
igorosip0v
commented
May 30, 2024
| @@ -18,6 +24,8 @@ export const ClientContent = () => { | |||
| <hr /> | |||
|
|
|||
| <div className="grid gap-y-8"> | |||
| <VersionsNoSSR /> | |||
There was a problem hiding this comment.
@andy-t-wang Made it dynamic import because in the demo we are using window.WorldApp inside the JSX markup, and nextjs still trying to hydrate this component end it cause hydration error, text inside <pre*>window.WorldApp</pre*> is not matches between server and client because window is not exist on server
| MiniKitInstallErrorMessage, | ||
| } from "@worldcoin/minikit-js"; | ||
|
|
||
| export const Versions = () => { |
There was a problem hiding this comment.
Result
Desktop:
From the app:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After approval we need to adjust specs