Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Fix Event::SoftwareVersionBlocked #81

Merged
merged 1 commit into from
Apr 18, 2024
Merged

ui: Fix Event::SoftwareVersionBlocked #81

merged 1 commit into from
Apr 18, 2024

Conversation

karelispanagiotis
Copy link
Member

@karelispanagiotis karelispanagiotis commented Apr 18, 2024 •
edited
Loading

Behavior before:

  1. The LED ring progressed approx 90% and stayed there even though the signup was finished.
  2. The LED ring was not cleared after the signup.
  3. The operator LEDs were not yellow after the failed signup

This PR solves all the above problems.

@karelispanagiotis karelispanagiotis force-pushed the karelis/orb-ui-sw-version-blocked-fix branch from 392da12 to 2791525 Compare April 18, 2024 17:21
andronat
andronat approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@andronat andronat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andronat andronat self-assigned this Apr 18, 2024
@andronat andronat enabled auto-merge (squash) April 18, 2024 17:22
@TheButlah TheButlah changed the title orb-ui: Fix Event::SoftwareVersionBlocked ui: Fix Event::SoftwareVersionBlocked Apr 18, 2024
@andronat andronat merged commit 4f1805c into main Apr 18, 2024
9 checks passed
@andronat andronat deleted the karelis/orb-ui-sw-version-blocked-fix branch April 18, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andronat andronat andronat approved these changes

@fouge fouge Awaiting requested review from fouge

Assignees

@andronat andronat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karelispanagiotis @andronat