Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more countries #31

Closed
wants to merge 1 commit into from
Closed

Conversation

theontho
Copy link

@theontho theontho commented May 18, 2022

Fix #15 (japan)
Fix #27 (also japan)
Fix #16 (china)
Fix #26 (singapore)
Fix #1 (austria)

Add taiwan, netherlands
Try to add Brazil

Fix worthbak#15 (japan)
Fix worthbak#16 (china)
Fix worthbak#26 (singapore)
Add worthbak#1 (austria)

Add taiwan, netherlands
Try to add Brazil
@perondeau
Copy link

Can you add support for France ?

@worthbak
Copy link
Owner

worthbak commented Oct 1, 2022

Apologies for leaving this PR open for so long. The difficulty with adding new countries is that the more countries I add, the harder it is to update the app to support new products (for example, adding the Apple Watch Ultra took quite some time because Apple chose to give the Ultra slightly different model-number variations for many countries, requiring me to check them all).

That said, I would like to add more countries, but will need to do so slowly. Your PR doesn't account for some regional variations in existing products (namely the iPhone, iPad, and now the Watch), so I'm going to close it. If I come up with a better way for community members to contribute country-specific data in the future, then I hope you'll contribute!

@worthbak worthbak closed this Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants