Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with Kirby devkit #3

Open
georgobermayr opened this issue Oct 16, 2018 · 0 comments
Open

Not working with Kirby devkit #3

georgobermayr opened this issue Oct 16, 2018 · 0 comments

Comments

@georgobermayr
Copy link

Hi,

when I try to install the plugin with the Kirby devkit my site goes down with this errors in console:

[16-Oct-2018 11:12:47 UTC] PHP Warning:  Use of undefined constant DS - assumed 'DS' (this will throw an Error in a future version of PHP) in /Users/georgobermayr/Documents/Git/kirby-test/site/plugins/kirby-git/index.php on line 3
[16-Oct-2018 11:12:47 UTC] PHP Warning:  require_once(/Users/georgobermayr/Documents/Git/kirby-test/site/plugins/kirby-gitDSGitHelper.php): failed to open stream: No such file or directory in /Users/georgobermayr/Documents/Git/kirby-test/site/plugins/kirby-git/index.php on line 3
[16-Oct-2018 11:12:47 UTC] PHP Fatal error:  require_once(): Failed opening required '/Users/georgobermayr/Documents/Git/kirby-test/site/plugins/kirby-gitDSGitHelper.php' (include_path='.:/Applications/MAMP/bin/php/php7.2.8/lib/php') in /Users/georgobermayr/Documents/Git/kirby-test/site/plugins/kirby-git/index.php on line 3

I think this is an issue with devkit and / or Composer.

If I add something like defined('DS') ? null : define('DS', DIRECTORY_SEPARATOR); to your index.php it works. But I think there should be a better solution?

Thank you,
Georg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant