Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include short-term effects in sizing #26

Open
wouterpeere opened this issue Sep 12, 2022 · 4 comments
Open

Include short-term effects in sizing #26

wouterpeere opened this issue Sep 12, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@wouterpeere
Copy link
Owner

Right now, GHEtool ignores the internal capacity of the borehole, by making use of the equivalent borehole thermal resistance. This short-term effects however, can play an important role in some cases.

A resistance-capacitance model can be implemented like the one from (Minaei and Maerefat, 2017).

@wouterpeere wouterpeere added the enhancement New feature or request label Sep 12, 2022
@wouterpeere
Copy link
Owner Author

A first short-term effect (cylindrical correction) was added in issue #187

@LoneMeertens
Copy link
Collaborator

LoneMeertens commented Jun 13, 2024

Validation will done on two levels

Next steps should focus on the following improvements:

  • Develop a more general method for determining the far field radius that is applicable to non-rectangular shapes.
  • Calculate the fluid factor based on the borehole configuration.
  • Extend the numerical model to be able to handle double u-tubes

The sensitivity analysis should consider the following parameters:

  • Borehole spacing
  • The num_intervals parameter in the numerical model
  • Time step used in numerical model

@wouterpeere
Copy link
Owner Author

Hi @LoneMeertens,

Perhaps it is best to develop all the tasks you mentioned above before merging into the main branch? What do you think?

Best,
@wouterpeere

@LoneMeertens
Copy link
Collaborator

@wouterpeere I completely agree that the method must be robust and thoroughly validated for both single and double-U tubes before merging with the main branch. The extension to include sizing with double-U tube boreholes is already in place but has yet to be validated. I will keep you informed once the full validation is completed and the tasks mentioned above are implemented.

@wouterpeere wouterpeere removed this from the v2.3.0 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🏗 In progress
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants