Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCI - Beacon should report multiple background if found so all are excluded from LazyLoad #7193

Open
camilamadronero opened this issue Dec 17, 2024 · 0 comments

Comments

@camilamadronero
Copy link

Describe the bug
OCI is not detecting multiple background images. It's only excluding one from the LazyLoad, while the others are still lazyloaded.

To Reproduce
Steps to reproduce the behavior:

  1. Have a page with an element with multiple background images.
  2. Run OCI and LazyLoad for CSS background images on it
  3. See the resulting markup, with only one excluded image.
    Example:
    <div class="elementor-element elementor-element-1ac3863 e-con-full mobile-banner-link …" data-id="1ac3863" data-element_type="container" data-settings="{&quot;background_background&quot;:&quot;classic&quot;}" data-rocket-lazy-bg-91d08a9f-0ebc-4bfe-8173-55c8544ae776="excluded" data-rocket-lazy-bg-4bd7f57f-5e77-4641-976d-ab0f4b8e3ebf="loaded">

Expected behavior
Beacon should report multiple background if found so all are excluded from LazyLoad

Screenshots
Screenshot of the LCP element in the PageSpeed test: https://jmp.sh/Pr5ewoie

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Slack discussion: https://wp-media.slack.com/archives/C08N8J6VC/p1734451750055559?thread_ts=1733932259.948279&cid=C08N8J6VC
Site: https://zinius.lt/ - The old/affected LCP element has been replaced already
Old PageSpeed test - With the issue
Old LCP element:
<div class="elementor-element elementor-element-1ac3863 e-con-full mobile-banner-link …" data-id="1ac3863" data-element_type="container" data-settings="{&quot;background_background&quot;:&quot;classic&quot;}" data-rocket-lazy-bg-91d08a9f-0ebc-4bfe-8173-55c8544ae776="excluded" data-rocket-lazy-bg-4bd7f57f-5e77-4641-976d-ab0f4b8e3ebf="loaded">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant