Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WITH_PROTOBUF CMake flag for disabling protobuf serialization #7060

Closed
calcmogul opened this issue Sep 9, 2024 · 1 comment
Closed
Labels
build Monorepo organization, gradle/cmake, upstream_utils, etc type: feature Brand new functionality, features, pages, workflows, endpoints, etc.

Comments

@calcmogul
Copy link
Member

calcmogul commented Sep 9, 2024

SleipnirGroup/Choreo#727 is using wpimath's spline trajectory generator as an initial guess for the optimization problem. Building has proven difficult because it requires protobuf installed in CI. We don't need serialization, so we wrote a Python script to manually patch it out. However, upstream keeps breaking it in nontrivial ways.

An upstream CMake flag like WITH_PROTOBUF that disables protobuf would make our lives easier.

@calcmogul calcmogul added type: feature Brand new functionality, features, pages, workflows, endpoints, etc. build Monorepo organization, gradle/cmake, upstream_utils, etc labels Sep 9, 2024
@calcmogul calcmogul changed the title Add WITH_SERIALIZATION CMake flag for disabling struct and protobuf serialization Add WITH_PROTOBUF CMake flag for disabling protobuf serialization Sep 9, 2024
@PeterJohnson
Copy link
Member

Duplicate of #5887 re: protobuf disabling. Struct has no external dependencies and it should not be necessary to disable it.

@calcmogul calcmogul closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Monorepo organization, gradle/cmake, upstream_utils, etc type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

No branches or pull requests

2 participants