Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Notifier to use SafeThread #7768

Open
virtuald opened this issue Feb 6, 2025 · 0 comments
Open

Switch Notifier to use SafeThread #7768

virtuald opened this issue Feb 6, 2025 · 0 comments
Labels
type: feature Brand new functionality, features, pages, workflows, endpoints, etc.

Comments

@virtuald
Copy link
Member

virtuald commented Feb 6, 2025

If we did that, then Python wouldn't need to maintain its own separate notifier implementation, as SafeThread has an start/stop hook that we use to create a thread state and safely exit the thread at interpreter shutdown.

Would make solving robotpy/mostrobotpy#147 easier, but we'll have to do a hack for now.
@virtuald virtuald added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@virtuald