From e7ff8504ba94399c284e57213413d0090892de79 Mon Sep 17 00:00:00 2001 From: Jade Turner Date: Sun, 29 Sep 2024 23:49:34 +0800 Subject: [PATCH] review --- .../nativeutils/vendordeps/VendorDepTask.java | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/main/java/edu/wpi/first/nativeutils/vendordeps/VendorDepTask.java b/src/main/java/edu/wpi/first/nativeutils/vendordeps/VendorDepTask.java index 925e2cd..d587bab 100644 --- a/src/main/java/edu/wpi/first/nativeutils/vendordeps/VendorDepTask.java +++ b/src/main/java/edu/wpi/first/nativeutils/vendordeps/VendorDepTask.java @@ -50,16 +50,21 @@ public void install() throws IOException { String newFilename; try (BufferedReader reader = Files.newBufferedReader(dest)) { newFilename = new GsonBuilder().create().fromJson(reader, JsonDependency.class).fileName; + if (newFilename == null) { + getLogger().warn("Couldn't find fileName field in " + destString + "\n Aborting"); + return; + } } catch (IOException e) { throw new RuntimeException(e); } File file = new File(destString); - int lastPathSeperator = dest.toString().lastIndexOf('/'); - boolean didRename = file.renameTo(new File(dest.toString().substring(0, lastPathSeperator + 1) + newFilename)); - if (didRename == true) { - getLogger().info("File Succesfully Renamed"); + int lastPathSeparator = dest.toString().lastIndexOf('/'); + File newFile = new File(dest.toString().substring(0, lastPathSeparator + 1) + newFilename); + boolean didRename = file.renameTo(newFile); + if (didRename) { + getLogger().info("Succesfully renamed " + file.toString() + " to " + newFile.toString()); } else { - getLogger().warn("Failed to rename file"); + getLogger().warn("Failed to rename file " + file.toString() + " to " + newFile.toString()); } }