Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use canonical URLs when ogp_site_url is not configured #56

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Use canonical URLs when ogp_site_url is not configured #56

wants to merge 7 commits into from

Conversation

ItayZiv
Copy link
Collaborator

@ItayZiv ItayZiv commented Feb 25, 2022 •
edited
Loading

Fix support for automatically getting the ogp_site_url in RTD environments and in all environments by using the canonical URL that RTD configures in Sphinx (html_baseurl)
Closes #55.

@ItayZiv ItayZiv changed the title Fix RTD Support and use Canonical URL Use canonical URLs when ogp_site_url is not configured Feb 25, 2022
@ItayZiv
Copy link
Collaborator Author

ItayZiv commented Mar 20, 2022

Not sure if we should test if this runs

sphinxext-opengraph/sphinxext/opengraph/__init__.py

Line 79 in 3d43636

logger.info(

Also not 100% sure about the way readme is worded.

@ItayZiv ItayZiv marked this pull request as ready for review March 20, 2022 12:39
@Julian Julian mentioned this pull request Nov 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daltz333 Daltz333 Daltz333 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Canonical URL for ogp_site_url
2 participants
@ItayZiv @Daltz333