Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Doctor result is letter instead of number #14

Closed
joyously opened this issue Aug 15, 2014 · 8 comments
Closed

Plugin Doctor result is letter instead of number #14

joyously opened this issue Aug 15, 2014 · 8 comments

Comments

@joyously
Copy link

I loaded a theme zip file to Plugin Doctor desktop version and it gave me the result:
Requires at least: M

It listed one deprecated function, and all the functions on the right, but I have to go look at each one to find the version information.
The M could be from one file which listed:
get_post_format 3
get_template_part 3
have_posts 1
is_sticky 2
the_post 1
Unknown version information
Missing version information

@joyously
Copy link
Author

I narrowed it down. The function get_current_user_id has a version number of MU, so that messes up everything after it.
Also, function add_theme_page says N/A.

@oliverschloebe
Copy link
Member

Hi joyously!

The issue was caused by #13 and has been fixed.

Thanks!

@joyously
Copy link
Author

The fix for #13 certainly helped! I now get a number for the same zip file, and each function is showing a version number instead of an integer.

However, the end result number is not necessarily correct because the version number of MU still affects what comes after it. See attached screenshot and note the functions after the MU don't have a number.
capture619-plugin doctor - wpseek_bug

@oliverschloebe
Copy link
Member

Hey joyously, that's intentional. See the subheadings. :) Some functions don't have version information in their doc blocks, so I'm listing them under separate subheadings to clearify that version info are missing.

Image

@joyously
Copy link
Author

Wow, you should change how you present the information. I had no idea those were headings. They looked like warning messages you output as you went. Maybe it's because the first section doesn't have a header of that same size and also because you put out the header even if there's nothing under it.
Maybe the Missing and Unknown should go on the left with the Deprecated.

@oliverschloebe
Copy link
Member

You have probably guessed that I'm not a designer by now. :D But you're right. The headings might get lost there.

@oliverschloebe
Copy link
Member

Changed the layout of the "Function Breakdown" a little which should make the headings more obvious.

@joyously
Copy link
Author

Looks much better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants