Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to FitRates_Mono.py default variables make it fail to reproduce expected example output #9

Open
DLafayetteII opened this issue Jun 25, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@DLafayetteII
Copy link

DLafayetteII commented Jun 25, 2024

Development #7 made changes to not only the formating but the saved variables in the IRF. These variables need to be changed back to get something close to what is the expected output, namely:

'irf_type': 'GaussDiff' should be 'Gauss', and 'fwhm' :55 * ps should be 40 *ps.

Additionally, the pulse_power = 45 * nW needs to be 1000 * nW (This change was made in the 'small tweaks' patch)

@DLafayetteII DLafayetteII added the good first issue Good for newcomers label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant