Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving a Post to a Collection should replicate API's behaviour #9

Open
AngeloStavrow opened this issue Jun 30, 2020 · 0 comments
Open
Labels
bug Something isn't working

Comments

@AngeloStavrow
Copy link
Collaborator

AngeloStavrow commented Jun 30, 2020

The /api/collections/{COLLECTION_ALIAS}/move enpoint takes an array of post IDs as an argument and returns, in its response's data object, "an array of response envelopes: each with code and post (with full post data) on success, or code and error_msg on failure for any given post."

This is not the case for the WriteFreelyClient.movePost(postId: with modifyToken: to collectionAlias: completion:) method, which works with single post IDs and returns a Result<Bool, Error> in the completion handler.

This is classified a bug because it diverges from the behaviour of the API.

@AngeloStavrow AngeloStavrow added the bug Something isn't working label Jun 30, 2020
@AngeloStavrow AngeloStavrow self-assigned this Oct 15, 2020
@AngeloStavrow AngeloStavrow removed their assignment Sep 21, 2023
@AngeloStavrow AngeloStavrow added the hacktoberfest Eligible for Hacktoberfest 2023 label Sep 21, 2023
@AngeloStavrow AngeloStavrow removed the hacktoberfest Eligible for Hacktoberfest 2023 label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant