Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crashes on revoking location permission #31

Closed
robo-w opened this issue Feb 21, 2019 · 2 comments
Closed

App crashes on revoking location permission #31

robo-w opened this issue Feb 21, 2019 · 2 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@robo-w
Copy link
Contributor

robo-w commented Feb 21, 2019

Version 1.1.1
Android 6.0.1
originally reported in #30 by @heinrichmartin

GIVEN the app is closed
WHEN I retract the app's permission to the location data in the mobile's settings
THEN the app crashes
AND it crashes twice (two notifications from Android)

@robo-w robo-w added the bug Something isn't working label Feb 21, 2019
@robo-w
Copy link
Contributor Author

robo-w commented Feb 24, 2019

Cause:
On revoking the location permission, android restarts the service running in the background. On restart, it is started directly by android, and not via the MainActivity, where the location permission is checked. Therefore the whole app crashes.

Revoking the permission is blocking the main feature of the app. I think its fine to keep it this way, and show the user that the app cannot operate properly.

@robo-w robo-w added the wontfix This will not be worked on label Feb 24, 2019
@heinrichmartin heinrichmartin removed their assignment Feb 24, 2019
@heinrichmartin
Copy link
Contributor

Revoking the location permission was just a work around #32. Force stopping the app is another option that works fine.

@robo-w robo-w closed this as completed Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants