Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_get(Vec) and _get(Mat) should not allocate memory internally #18

Open
wrtobin opened this issue May 3, 2018 · 1 comment
Open

_get(Vec) and _get(Mat) should not allocate memory internally #18

wrtobin opened this issue May 3, 2018 · 1 comment
Assignees
Labels
enhancement New feature or request invalid This doesn't seem right

Comments

@wrtobin
Copy link
Owner

wrtobin commented May 3, 2018

_get(Vec) and _get(Mat) currently allocate the output array, but the user aware of what the array size needs to be, should change the output semantics so the memory allocation happens in user-space. Both for simplicity in terms of memory ownership and so the same array can be used to retrieve values multiple times since that is much more efficient.

@wrtobin wrtobin changed the title _get(Vec) and _get(Mat) currently allocate the output array, but the user aware of what the array size needs to be, should change the output semantics so the memory allocation happens in user-space. Both for simplicity in terms of memory ownership and so the same array can be used to retrieve values multiple times since that is much more efficient. _get(Vec) and _get(Mat) should not allocate memory internally May 3, 2018
@wrtobin wrtobin self-assigned this May 3, 2018
@wrtobin wrtobin added bug Something isn't working enhancement New feature or request invalid This doesn't seem right and removed bug Something isn't working labels May 3, 2018
@wrtobin
Copy link
Owner Author

wrtobin commented May 3, 2018

should the interface change from _get(XXX, ..... , scalar ** vals) to _get(XXX, ....., scalar * vals) since the user in now responsible for allocating the output array?

this would reduce ambiguity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant