Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the policy file extension validation for the rest apis #11162

Closed
wants to merge 1 commit into from
Closed

Add the policy file extension validation for the rest apis #11162

wants to merge 1 commit into from

Conversation

lakshithagunasekara
Copy link

@codecov
Copy link

codecov bot commented Mar 16, 2022 •
edited
Loading

Codecov Report

Merging #11162 (7148cd5) into master (d9afb68) will increase coverage by 15.85%.
The diff coverage is 12.50%.

@@              Coverage Diff              @@
##             master   #11162       +/-   ##
=============================================
+ Coverage     21.79%   37.64%   +15.85%     
- Complexity        0     3578     +3578     
=============================================
  Files          1144     1722      +578     
  Lines         98502   127664    +29162     
  Branches      13612    17633     +4021     
=============================================
+ Hits          21468    48060    +26592     
+ Misses        74242    73383      -859     
- Partials       2792     6221     +3429
Flag Coverage Δ
integration_tests 28.85% <12.50%> (?)
unit_tests 21.74% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rest/api/publisher/v1/impl/ApisApiServiceImpl.java 10.84% <0.00%> (ø)
...isher/v1/impl/OperationPoliciesApiServiceImpl.java 1.38% <0.00%> (ø)
.../api/publisher/v1/utils/RestApiPublisherUtils.java 0.00% <ø> (ø)
...java/org/wso2/carbon/apimgt/impl/APIConstants.java 59.70% <100.00%> (+4.84%) ⬆️
...g/wso2/carbon/apimgt/persistence/APIConstants.java 46.15% <0.00%> (-8.40%) ⬇️
...hrottling/publisher/ThrottleDataPublisherPool.java 80.95% <0.00%> (-4.05%) ⬇️
...lers/throttling/ApplicationThrottleController.java 78.18% <0.00%> (-3.73%) ⬇️
...gt/impl/throttling/GlobalThrottleEngineClient.java 87.12% <0.00%> (-3.60%) ⬇️
...arbon/apimgt/impl/indexing/indexer/PDFIndexer.java 92.85% <0.00%> (-3.44%) ⬇️
...imgt/gateway/utils/APIMgtGoogleAnalyticsUtils.java 27.11% <0.00%> (-3.39%) ⬇️
... and 1188 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9afb68...7148cd5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tharindu1st tharindu1st Awaiting requested review from tharindu1st tharindu1st is a code owner

@malinthaprasan malinthaprasan Awaiting requested review from malinthaprasan

@chamilaadhi chamilaadhi Awaiting requested review from chamilaadhi chamilaadhi is a code owner

@Krishanx92 Krishanx92 Awaiting requested review from Krishanx92

@mushthaq33 mushthaq33 Awaiting requested review from mushthaq33

@bhathiya bhathiya Awaiting requested review from bhathiya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need a validation to reject policy files with invalid file extensions
1 participant
@lakshithagunasekara