Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve idp deletion error scenario for user defined federated authenticator #22056

Closed
Thisara-Welmilla opened this issue Dec 17, 2024 · 1 comment

Comments

@Thisara-Welmilla
Copy link
Contributor

Task issue:

The existing implementation deletes the associated action first and then deletes the Identity Provider (IDP) from the database. If an error occurs while deleting the IDP, a rollback mechanism adds the action back. However, the newly added action does not retain the original ID, causing inconsistencies.

To address this, we are changing the implementation to delete the IDP from the database first, followed by deleting the associated action. However, if an error occurs during the deletion of the action, it will result in a stale action remaining in the system. Added a warn for that.

@Thisara-Welmilla
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants