Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frame Variable Storage #17

Open
wtheisen opened this issue Jul 31, 2019 · 3 comments
Open

Frame Variable Storage #17

wtheisen opened this issue Jul 31, 2019 · 3 comments

Comments

@wtheisen
Copy link
Owner

So frames need to have member variables and right now they're stored as actual variables of the class. However I think as we move forward this might cause problems with extensibility. I was thinking it might make more sense to instead have a single dictionary in each frames called "options" or something and then the code can just store any kind of value it likes. This also allows code to make assumptions that a variable is there and means we don't need to keep adding member variables into frames.

What do you guys think about that?
@sambattalio @ginglis13

@wtheisen
Copy link
Owner Author

Whoops I meant the view class not the frame class

@sambattalio
Copy link
Collaborator

That would be nice i think especially since some things like pagination could use that

@wtheisen
Copy link
Owner Author

It would allow frames to customize and assume a lot of things at a significant cost of standardization. The more I think about it the more we should probably do a mixture of the two. Keep SITE as a member variable but maybe break some of the more specific stuff out into a dict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants