Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of comparison operators in Fauna::ForageValues #13

Open
wtraylor opened this issue Mar 28, 2020 · 0 comments
Open

Improve performance of comparison operators in Fauna::ForageValues #13

wtraylor opened this issue Mar 28, 2020 · 0 comments
Labels
enhancement New feature or request refactoring Restructuring or rewriting of code

Comments

@wtraylor
Copy link
Owner

  1. Use iterators, like for (auto i : ...), instead of classic integer iterators and indexed access. First do research if array indexing is more costly than iterators.
  2. Implement the operators also for comparison with double. This prevents casting double to Fauna::ForageValues, which I suspect is rather costly.
@wtraylor wtraylor added enhancement New feature or request refactoring Restructuring or rewriting of code labels Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request refactoring Restructuring or rewriting of code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wtraylor