Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename parameters hft.life_history.physical_maturity* #49

Open
wtraylor opened this issue Jun 30, 2021 · 0 comments
Open

Rename parameters hft.life_history.physical_maturity* #49

wtraylor opened this issue Jun 30, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@wtraylor
Copy link
Owner

Currently, there are two parameters hft.life_history.physical_maturity_female and hft.life_history.physical_maturity_male.

The naming is inconsistent with hft.body_mass.male and hft.body_mass.female. It would make more sense to have male and female as sub-parameters of physical_maturity (separated by a dot).

Then we can also write it concisely like this:

[hft.life_history]
physical_maturity = { female = 3, male = 3}

For backward compatibility, the old names should still be valid but marked as deprecated. Internally, the member names of class Fauna::Hft don’t need to be changed because in the member variable names the dots are replaced with underscores anyway.

@wtraylor wtraylor added the enhancement New feature or request label Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant