From fe474187005bc1f9b4fc77cc6eb1e2fcbbca0057 Mon Sep 17 00:00:00 2001 From: Keith James Date: Wed, 29 May 2024 09:58:09 +0100 Subject: [PATCH] Add test skip for a bug fixed in iRODS 4.3.2 --- tests/test_irods.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/test_irods.py b/tests/test_irods.py index e8a08b3..9c6cbca 100644 --- a/tests/test_irods.py +++ b/tests/test_irods.py @@ -817,7 +817,8 @@ def test_get_checksum(self, simple_data_object): @m.it("Can have its checksum verified as good") @pytest.mark.skipif( - irods_version() <= (4, 2, 10), reason="requires iRODS server >4.2.10" + irods_version() <= (4, 2, 10), + reason=f"requires iRODS server >4.2.10; version is {irods_version()}", ) def test_verify_checksum_good(self, simple_data_object): obj = DataObject(simple_data_object) @@ -829,7 +830,8 @@ def test_verify_checksum_good(self, simple_data_object): @m.it("Can have its checksum verified as bad") @pytest.mark.skipif( - irods_version() <= (4, 2, 10), reason="requires iRODS server >4.2.10" + irods_version() <= (4, 2, 10), + reason=f"requires iRODS server >4.2.10; version is {irods_version()}", ) def test_verify_checksum_bad(self, invalid_checksum_data_object): obj = DataObject(invalid_checksum_data_object) @@ -1118,6 +1120,10 @@ def test_trim_valid_replica_zero(self, simple_data_object, sql_test_utilities): with pytest.raises(RodsError, match="trim error"): obj.trim_replicas(min_replicas=0, valid=True, invalid=False) + @pytest.mark.skipif( + irods_version() >= (4, 3, 2), + reason=f"fixed in iRODS 4.3.2; version is {irods_version()}", + ) @m.describe("Data objects with invalid replicas") @m.context("When trimming would violate the minimum replica count") @m.it("Still trims invalid replicas")