Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AEM-8 should be extended to detect usages of SlingServlet... without the component annotation #144

Open
kwin opened this issue Apr 25, 2019 · 1 comment
Labels

Comments

@kwin
Copy link

kwin commented Apr 25, 2019

The new recommended way to register Sling Servlet is via the annotations maintained at https://github.com/apache/sling-org-apache-sling-servlets-annotations (compare with https://sling.apache.org/documentation/the-sling-engine/servlets.html). Using those meta annotations without @Component should emit a warning. Would be nice to include this check as well

@chutch
Copy link
Contributor

chutch commented May 23, 2019

Hey @kwin , thanks for raising the issue. I think that as a part of this ticket we should also implement rules with recommendations, which would depend on version of AEM you pass to analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants