Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget | Service Check - Add diff on expected vs actual body #292

Open
basia-wulnikowska opened this issue Oct 23, 2020 · 2 comments · May be fixed by #402
Open

Widget | Service Check - Add diff on expected vs actual body #292

basia-wulnikowska opened this issue Oct 23, 2020 · 2 comments · May be fixed by #402
Assignees
@GrzegorzBednarski @mGasiorek998
Labels
enhancement New feature or request low priority Tasks with this label are considered less important

Comments

@basia-wulnikowska
Copy link
Contributor

Short Description

Curently in Service Check, if we compare body content - we can only see if it's OK or NOT. It would be a good practice to add there diff when Service Check will catch that content is not what we expected.

Solution

Two-side diff: one field on left side with expectation, right side with actual content. Maybe with red text on parts that differ.
@basia-wulnikowska basia-wulnikowska added the enhancement New feature or request label Oct 23, 2020
@szymon-owczarzak szymon-owczarzak added the low priority Tasks with this label are considered less important label Mar 23, 2021
@szymon-owczarzak szymon-owczarzak changed the title Low priority: Service check -add diff on expected vs actual body Service Check Widget | Add diff on expected vs actual body Mar 23, 2021
@szymon-owczarzak szymon-owczarzak changed the title Service Check Widget | Add diff on expected vs actual body Widget | Service Check - Add diff on expected vs actual body Mar 23, 2021
@mGasiorek998 mGasiorek998 mentioned this issue Jun 22, 2021
Closed
7 tasks
@mGasiorek998 mGasiorek998 linked a pull request Jun 22, 2021 that will close this issue
Enhancement/service check diff #401
Closed
7 tasks
@mGasiorek998 mGasiorek998 linked a pull request Jun 22, 2021 that will close this issue
Open
7 tasks
@mGasiorek998 mGasiorek998 removed a link to a pull request Jun 22, 2021
Enhancement/service check diff #401
Closed
7 tasks
@mGasiorek998 mGasiorek998 linked a pull request Jun 22, 2021 that will close this issue
#292 | Service Check - Add diff on expected vs actual body #402
Open
7 tasks
@GrzegorzBednarski
Copy link
Collaborator

2021-07-20_11h31_40

@GrzegorzBednarski
Copy link
Collaborator

Sometimes response body didn't fit to dialog size. Please style it to always fit inside dialog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GrzegorzBednarski GrzegorzBednarski

@mGasiorek998 mGasiorek998

Labels
enhancement New feature or request low priority Tasks with this label are considered less important
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#292 | Service Check - Add diff on expected vs actual body wttech/cogboard
4 participants
@GrzegorzBednarski @szymon-owczarzak @basia-wulnikowska @mGasiorek998