From 402992a7200edb9bbc6f5bc7813b564f66dc189a Mon Sep 17 00:00:00 2001
From: tony chen <tony.zq.chen@gmail.com>
Date: Fri, 10 May 2024 13:57:36 +0800
Subject: [PATCH] fix: remove useless code fixd by RNSVG

Signed-off-by: tony chen <tony.zq.chen@gmail.com>
---
 .../__snapshots__/chart.test.tsx.snap         | 58 -------------------
 src/svgChart.tsx                              |  4 --
 2 files changed, 62 deletions(-)

diff --git a/src/__tests__/__snapshots__/chart.test.tsx.snap b/src/__tests__/__snapshots__/chart.test.tsx.snap
index df9518de..5dba933f 100644
--- a/src/__tests__/__snapshots__/chart.test.tsx.snap
+++ b/src/__tests__/__snapshots__/chart.test.tsx.snap
@@ -1067,7 +1067,6 @@ exports[`SvgChart Chart fire dispatchEventsToZRender correctly 3`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
             ]
           }
           stroke={
@@ -1076,7 +1075,6 @@ exports[`SvgChart Chart fire dispatchEventsToZRender correctly 3`] = `
               "type": 0,
             }
           }
-          strokeWidth={1}
         />
         <RNSVGPath
           d="M43 150.5L387 150.5"
@@ -1090,7 +1088,6 @@ exports[`SvgChart Chart fire dispatchEventsToZRender correctly 3`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
             ]
           }
           stroke={
@@ -1099,7 +1096,6 @@ exports[`SvgChart Chart fire dispatchEventsToZRender correctly 3`] = `
               "type": 0,
             }
           }
-          strokeWidth={1}
         />
         <RNSVGPath
           d="M43 120.5L387 120.5"
@@ -1113,7 +1109,6 @@ exports[`SvgChart Chart fire dispatchEventsToZRender correctly 3`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
             ]
           }
           stroke={
@@ -1122,7 +1117,6 @@ exports[`SvgChart Chart fire dispatchEventsToZRender correctly 3`] = `
               "type": 0,
             }
           }
-          strokeWidth={1}
         />
         <RNSVGPath
           d="M43 90.5L387 90.5"
@@ -1136,7 +1130,6 @@ exports[`SvgChart Chart fire dispatchEventsToZRender correctly 3`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
             ]
           }
           stroke={
@@ -1145,7 +1138,6 @@ exports[`SvgChart Chart fire dispatchEventsToZRender correctly 3`] = `
               "type": 0,
             }
           }
-          strokeWidth={1}
         />
         <RNSVGPath
           d="M43 60.5L387 60.5"
@@ -1159,7 +1151,6 @@ exports[`SvgChart Chart fire dispatchEventsToZRender correctly 3`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
             ]
           }
           stroke={
@@ -1168,7 +1159,6 @@ exports[`SvgChart Chart fire dispatchEventsToZRender correctly 3`] = `
               "type": 0,
             }
           }
-          strokeWidth={1}
         />
         <RNSVGPath
           d="M43 180.5L387 180.5"
@@ -1182,7 +1172,6 @@ exports[`SvgChart Chart fire dispatchEventsToZRender correctly 3`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
               "strokeLinecap",
             ]
           }
@@ -1193,7 +1182,6 @@ exports[`SvgChart Chart fire dispatchEventsToZRender correctly 3`] = `
             }
           }
           strokeLinecap={1}
-          strokeWidth={1}
         />
         <RNSVGPath
           d="M43.5 180L43.5 185"
@@ -1207,7 +1195,6 @@ exports[`SvgChart Chart fire dispatchEventsToZRender correctly 3`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
             ]
           }
           stroke={
@@ -1216,7 +1203,6 @@ exports[`SvgChart Chart fire dispatchEventsToZRender correctly 3`] = `
               "type": 0,
             }
           }
-          strokeWidth={1}
         />
         <RNSVGPath
           d="M215.5 180L215.5 185"
@@ -1230,7 +1216,6 @@ exports[`SvgChart Chart fire dispatchEventsToZRender correctly 3`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
             ]
           }
           stroke={
@@ -1239,7 +1224,6 @@ exports[`SvgChart Chart fire dispatchEventsToZRender correctly 3`] = `
               "type": 0,
             }
           }
-          strokeWidth={1}
         />
         <RNSVGPath
           d="M387.5 180L387.5 185"
@@ -1253,7 +1237,6 @@ exports[`SvgChart Chart fire dispatchEventsToZRender correctly 3`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
             ]
           }
           stroke={
@@ -1262,7 +1245,6 @@ exports[`SvgChart Chart fire dispatchEventsToZRender correctly 3`] = `
               "type": 0,
             }
           }
-          strokeWidth={1}
         />
         <RNSVGText
           alignmentBaseline="middle"
@@ -1784,7 +1766,6 @@ exports[`SvgChart Chart renders correctly 2`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
             ]
           }
           stroke={
@@ -1793,7 +1774,6 @@ exports[`SvgChart Chart renders correctly 2`] = `
               "type": 0,
             }
           }
-          strokeWidth={1}
         />
         <RNSVGPath
           d="M43 150.5L387 150.5"
@@ -1807,7 +1787,6 @@ exports[`SvgChart Chart renders correctly 2`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
             ]
           }
           stroke={
@@ -1816,7 +1795,6 @@ exports[`SvgChart Chart renders correctly 2`] = `
               "type": 0,
             }
           }
-          strokeWidth={1}
         />
         <RNSVGPath
           d="M43 120.5L387 120.5"
@@ -1830,7 +1808,6 @@ exports[`SvgChart Chart renders correctly 2`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
             ]
           }
           stroke={
@@ -1839,7 +1816,6 @@ exports[`SvgChart Chart renders correctly 2`] = `
               "type": 0,
             }
           }
-          strokeWidth={1}
         />
         <RNSVGPath
           d="M43 90.5L387 90.5"
@@ -1853,7 +1829,6 @@ exports[`SvgChart Chart renders correctly 2`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
             ]
           }
           stroke={
@@ -1862,7 +1837,6 @@ exports[`SvgChart Chart renders correctly 2`] = `
               "type": 0,
             }
           }
-          strokeWidth={1}
         />
         <RNSVGPath
           d="M43 60.5L387 60.5"
@@ -1876,7 +1850,6 @@ exports[`SvgChart Chart renders correctly 2`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
             ]
           }
           stroke={
@@ -1885,7 +1858,6 @@ exports[`SvgChart Chart renders correctly 2`] = `
               "type": 0,
             }
           }
-          strokeWidth={1}
         />
         <RNSVGPath
           d="M43 180.5L387 180.5"
@@ -1899,7 +1871,6 @@ exports[`SvgChart Chart renders correctly 2`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
               "strokeLinecap",
             ]
           }
@@ -1910,7 +1881,6 @@ exports[`SvgChart Chart renders correctly 2`] = `
             }
           }
           strokeLinecap={1}
-          strokeWidth={1}
         />
         <RNSVGPath
           d="M43.5 180L43.5 185"
@@ -1924,7 +1894,6 @@ exports[`SvgChart Chart renders correctly 2`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
             ]
           }
           stroke={
@@ -1933,7 +1902,6 @@ exports[`SvgChart Chart renders correctly 2`] = `
               "type": 0,
             }
           }
-          strokeWidth={1}
         />
         <RNSVGPath
           d="M215.5 180L215.5 185"
@@ -1947,7 +1915,6 @@ exports[`SvgChart Chart renders correctly 2`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
             ]
           }
           stroke={
@@ -1956,7 +1923,6 @@ exports[`SvgChart Chart renders correctly 2`] = `
               "type": 0,
             }
           }
-          strokeWidth={1}
         />
         <RNSVGPath
           d="M387.5 180L387.5 185"
@@ -1970,7 +1936,6 @@ exports[`SvgChart Chart renders correctly 2`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
             ]
           }
           stroke={
@@ -1979,7 +1944,6 @@ exports[`SvgChart Chart renders correctly 2`] = `
               "type": 0,
             }
           }
-          strokeWidth={1}
         />
         <RNSVGText
           alignmentBaseline="middle"
@@ -2431,7 +2395,6 @@ exports[`SvgChart Chart renders correctly 2`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
             ]
           }
           stroke={
@@ -2440,7 +2403,6 @@ exports[`SvgChart Chart renders correctly 2`] = `
               "type": 0,
             }
           }
-          strokeWidth={1}
         />
         <RNSVGPath
           d="M1 0A1 1 0 1 1 1 -0.0001"
@@ -2464,7 +2426,6 @@ exports[`SvgChart Chart renders correctly 2`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
             ]
           }
           stroke={
@@ -2473,7 +2434,6 @@ exports[`SvgChart Chart renders correctly 2`] = `
               "type": 0,
             }
           }
-          strokeWidth={1}
         />
       </RNSVGGroup>
       <RNSVGDefs>
@@ -2600,7 +2560,6 @@ exports[`SvgChart Chart renders correctly when handleGesture false 2`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
             ]
           }
           stroke={
@@ -2609,7 +2568,6 @@ exports[`SvgChart Chart renders correctly when handleGesture false 2`] = `
               "type": 0,
             }
           }
-          strokeWidth={1}
         />
         <RNSVGPath
           d="M43 150.5L387 150.5"
@@ -2623,7 +2581,6 @@ exports[`SvgChart Chart renders correctly when handleGesture false 2`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
             ]
           }
           stroke={
@@ -2632,7 +2589,6 @@ exports[`SvgChart Chart renders correctly when handleGesture false 2`] = `
               "type": 0,
             }
           }
-          strokeWidth={1}
         />
         <RNSVGPath
           d="M43 120.5L387 120.5"
@@ -2646,7 +2602,6 @@ exports[`SvgChart Chart renders correctly when handleGesture false 2`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
             ]
           }
           stroke={
@@ -2655,7 +2610,6 @@ exports[`SvgChart Chart renders correctly when handleGesture false 2`] = `
               "type": 0,
             }
           }
-          strokeWidth={1}
         />
         <RNSVGPath
           d="M43 90.5L387 90.5"
@@ -2669,7 +2623,6 @@ exports[`SvgChart Chart renders correctly when handleGesture false 2`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
             ]
           }
           stroke={
@@ -2678,7 +2631,6 @@ exports[`SvgChart Chart renders correctly when handleGesture false 2`] = `
               "type": 0,
             }
           }
-          strokeWidth={1}
         />
         <RNSVGPath
           d="M43 60.5L387 60.5"
@@ -2692,7 +2644,6 @@ exports[`SvgChart Chart renders correctly when handleGesture false 2`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
             ]
           }
           stroke={
@@ -2701,7 +2652,6 @@ exports[`SvgChart Chart renders correctly when handleGesture false 2`] = `
               "type": 0,
             }
           }
-          strokeWidth={1}
         />
         <RNSVGPath
           d="M43 180.5L387 180.5"
@@ -2715,7 +2665,6 @@ exports[`SvgChart Chart renders correctly when handleGesture false 2`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
               "strokeLinecap",
             ]
           }
@@ -2726,7 +2675,6 @@ exports[`SvgChart Chart renders correctly when handleGesture false 2`] = `
             }
           }
           strokeLinecap={1}
-          strokeWidth={1}
         />
         <RNSVGPath
           d="M43.5 180L43.5 185"
@@ -2740,7 +2688,6 @@ exports[`SvgChart Chart renders correctly when handleGesture false 2`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
             ]
           }
           stroke={
@@ -2749,7 +2696,6 @@ exports[`SvgChart Chart renders correctly when handleGesture false 2`] = `
               "type": 0,
             }
           }
-          strokeWidth={1}
         />
         <RNSVGPath
           d="M215.5 180L215.5 185"
@@ -2763,7 +2709,6 @@ exports[`SvgChart Chart renders correctly when handleGesture false 2`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
             ]
           }
           stroke={
@@ -2772,7 +2717,6 @@ exports[`SvgChart Chart renders correctly when handleGesture false 2`] = `
               "type": 0,
             }
           }
-          strokeWidth={1}
         />
         <RNSVGPath
           d="M387.5 180L387.5 185"
@@ -2786,7 +2730,6 @@ exports[`SvgChart Chart renders correctly when handleGesture false 2`] = `
             [
               "fill",
               "stroke",
-              "strokeWidth",
             ]
           }
           stroke={
@@ -2795,7 +2738,6 @@ exports[`SvgChart Chart renders correctly when handleGesture false 2`] = `
               "type": 0,
             }
           }
-          strokeWidth={1}
         />
         <RNSVGText
           alignmentBaseline="middle"
diff --git a/src/svgChart.tsx b/src/svgChart.tsx
index 9a91c992..ec6f6056 100644
--- a/src/svgChart.tsx
+++ b/src/svgChart.tsx
@@ -155,10 +155,6 @@ function SvgEle(props: SVGVEleProps) {
   if (tag === 'path') {
     // 全部数据为空，iOS渲染有问题，无效的path过滤掉
     if (!attrs.d) return null;
-    // fix: add default strokeWidth for stroke
-    if (attrs.stroke && attrs.strokeWidth === undefined) {
-      attrs.strokeWidth = 1;
-    }
     return <Path {...attrs} />;
   }
   if (tag === 'linearGradient' || tag === 'radialGradient') {