Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"InnerMaxHeight" not found #1

Open
Abe101 opened this issue Sep 13, 2022 · 0 comments
Open

"InnerMaxHeight" not found #1

Abe101 opened this issue Sep 13, 2022 · 0 comments

Comments

@Abe101
Copy link

Abe101 commented Sep 13, 2022

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Found an issue with "InnerMaxHeight" not found. So the variable was not declared but assigned a value out of the blue. What I found further was that this wasn't being used anywhere so I thought its okay if it were to be gone unless its supposed to be used somewhere else.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-skewable-view/SkewableView.js b/node_modules/react-native-skewable-view/SkewableView.js
index e77eb79..f7c2dc4 100644
--- a/node_modules/react-native-skewable-view/SkewableView.js
+++ b/node_modules/react-native-skewable-view/SkewableView.js
@@ -60,7 +60,6 @@ export default class SkewableView extends Component {
             } else {
                 renderable = false;
             }
-            innerMaxHeight = innerHeight;
             innerHeight = innerHeight * Math.cos(angleRad) - innerWidth/2 * Math.tan(angleRad);
             innerHeight = Math.floor(innerHeight);
             translateX = -(innerWidth-this.props.boundingBoxWidth)/2;

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant