Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Armor name weirdness #19

Open
wwylele opened this issue May 23, 2022 · 1 comment
Open

Armor name weirdness #19

wwylele opened this issue May 23, 2022 · 1 comment

Comments

@wwylele
Copy link
Owner

wwylele commented May 23, 2022

at

.get(armor_series.armor_series.0 as usize); // ?!
and
let name = msg
.entries
.get(id)
.with_context(|| format!("Cannot find name for armor {:?}", armor.pl_armor_id))?; // ?!
let explain = explain_msg
.entries
.get(id)
.with_context(|| format!("Cannot find name for armor {:?}", armor.pl_armor_id))?; // ?!

where we look up the armor name from msg, unlike other names, we uses armor ID to match against msg entry index, instead of the msg entry name. This appears to be the correct matching, but why is it? Is this the actually correct method, or there is a hidden armor ID -> msg entry name mapping somewhere? Could we also be wrong about using msg entry name anywhere else?

@dtlnor
Copy link
Contributor

dtlnor commented May 23, 2022

don't know if this discussion about msg file and GUIDs in discord server modding heaven useful for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants